Testing: upgrade HTML to identify mis-cased anchors #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #238
The version of HTML Proofer that we were using wasn't identifying situations where internal links were broken because of uppercase characters in all-lowercase links (or other variations of case errors). This upgrades just our testing libraries (i.e. Jekyll is not upgraded) to get a new version of HTML Proofer that does verify correct casing.
You can generate the same dependency changes as in this PR by running the following command on master:
If you don't run the above command but you do have this PR in your history (e.g., it's been merged to master), you can update your dependencies by running:
You can verify that incorrect casing is detected by running
makewith the upgraded HTML Proofer version by with the first commit in this PR dropped (as it fixes a previously-undetected incorrectly cased link).