Add Wasabi RBF notification support #282
Conversation
|
Concept ACK. #2670 is merged, so this is no longer draft. |
|
Very cool @nopara73 , thanks for the PR! Should we wait for the next release? That way I can test and also bump tested on version from version 1.1.6 to 1.1.10. Or I can go off the latest RC if you prefer? |
|
Please go with the RC: https://github.com/zkSNACKs/WalletWasabi/releases |
|
I think the compatibility site should only include full releases, not developer branches or RCs. |
|
It makes sense. I will get back here after the release. |
jnewbery
added
the
compatibility
|
The release is out: https://github.com/zkSNACKs/WalletWasabi/releases |
|
@nopara73 Great! Since we are bumping the version from version 1.1.6 to 1.1.10 on the matrix, I also want to just make sure nothing else pertinent to the matrix changed and also grab a screenshot image of the new notification to add to this PR. Sound good? |
|
We started signalling randomly RBF for 2% of our transactions, but I guess that's insignificant, I just noted it for completeness. |
|
@nopara73 Good to know on the 2% rbf signaling. Ive added that note as well as a screenshot of the new notification, and a bump to the tested on and version number. Let me know if those look ok. |
|
This is correct. |
bitschmidty
force-pushed
the
patch-1
branch
2 times, most recently
from
be6528c to
c71fc43
Compare
|
Rebased on master. Squashed. |
PR implements it: WalletWasabi/WalletWasabi#2670
Messages: