Skip to content

News: add 70 (2019-10-30) #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

harding
Copy link
Collaborator

@harding harding commented Oct 28, 2019

No description provided.

Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good short newsletter this week! Only one nit inline. Otherwise ACK.

## News

- **LN simplified commitments:** in two separate threads, developers
from LND discussed their work on implementing simplified commitments,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'developers from Lightning Labs' or 'developers of LND' (Lightning Labs is the company, LND the product)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an important distinction, thank you for mentioning it. I'll edit.

@harding
Copy link
Collaborator Author

harding commented Oct 28, 2019

Pushed edit for @jnewbery feedback (thanks!), added a bullet for the Optech schnorr/taproot workshop, and added a short sentence and link to the PR for the LN simplified commitment previously described.

notebooks, GitHub repositories, and more information produced for the
schnorr and taproot workshops held in San Francisco and New York
City last month. These explain the fundamentals of both proposals,
guide students though actually using them, and then describe strategies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/students though/students through/

@jnewbery
Copy link
Contributor

One typo, otherwise ACK 19d5e93

@harding harding force-pushed the 2019-10-30-newsletter branch from 19d5e93 to b6886ac Compare October 29, 2019 17:22
@harding
Copy link
Collaborator Author

harding commented Oct 29, 2019

Rebased on master to pull in the schnorr/taproot blog post, updated link to point to it, added C-Lightning release, and fixed typo identified by @jnewbery (thanks!). All FIXMEs fixed now, so this should pass tests.

Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK b6886ac

and allows you keep your HD wallet seed encrypted when `lightningd`
isn't running---plus many other features and several bug fixes.

- **Help Bitcoin Core release candidate:** experienced users are encouraged to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 'Help test Bitcoin Core release candidate'?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Perhaps "Help test the Bitcoin Core release candidate:"

Copy link
Collaborator

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent and interesting newsletter! One typo (PostgreSQL) and a few nits below. I did not verify the links at the bottom. Cheers.

## Action items

- **Upgrade to C-Lightning 0.7.3:** this latest [release][c-lightning
0.7.3] adds support for a PostgresSQL backend, makes it possible to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/PostgresSQL/PostgreSQL/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly worth mentioning "in addition to SQLite3" (IIRC)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. A note for anyone else reviewing: this is wrong in the C-Lightning release notes; I checked that the spelling @jonatack proposes is the same as being used by the upstream PostgreSQL project.


- **Help Bitcoin Core release candidate:** experienced users are encouraged to
help test the latest release candidates for the upcoming version of
[Bitcoin Core][Bitcoin Core 0.19.0].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps provide a link to the testing meta-issue for test reports (or filing a separate issue in case of problems found).


## News

- **LN simplified commitments:** in two separate threads, developers
Copy link
Collaborator

@jonatack jonatack Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly s/threads/mailing list threads (or) lightning-dev mailing list threads/

LN protocol specification.

- **Publication of videos and study material from schnorr/taproot workshop:**
Optech published a [blog post][taproot workshop] with links to videos, Jupyter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: sometimes Optech writes "jupyter" and other times "Jupyter"... possibly a candidate for the style guide


- [Why does hashing public keys not actually provide any quantum resistance?]({{bse}}91049)
Andrew Chow lists several considerations regarding public keys and quantum
resistance including: needing to reveal the public key during spending, the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: add a comma after "resistance", remove the colon, and s/needing/the need/

branch and will probably not be released until version 0.20, expected
about six months from now. BIP70 was made optional in [version
0.18.0][core 0.18.0] and will be disabled by default in the upcoming
0.19.0, see [Newsletter #19][pr14451] for more information.
Copy link
Collaborator

@jonatack jonatack Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/, see/. See (or) ; see/

@moneyball
Copy link
Contributor

ACK

@harding
Copy link
Collaborator Author

harding commented Oct 30, 2019

Pushed (hopefully) final edits based on @jnewbery and @jonatack feedback (thanks). I split the edits into two commits to make it easier to squash this down into separate commits for the newsletter text added by @bitschmidty and for the text added by myself.

help test the latest release candidates for the upcoming version of
[Bitcoin Core][Bitcoin Core 0.19.0].
[Bitcoin Core][Bitcoin Core 0.19.0] and [report][Bitcoin Core #17079]
any issues you find.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you want to get into the details, but what is desired afaict is for people to report their RC testing in the meta-issue (to reassure the maintainers that testing is taking place and for which platforms) and to open a separate issue if a problem is encountered while testing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's confusing. I'm going to drop mention of this issue.

@harding harding force-pushed the 2019-10-30-newsletter branch from c413436 to 125eb9f Compare October 30, 2019 13:10
@bitschmidty
Copy link
Contributor

ACK 125eb9f

@bitschmidty bitschmidty merged commit 8f511e6 into bitcoinops:master Oct 30, 2019
@bitschmidty
Copy link
Contributor

Oh what a pity
Last weeks missed ditty
Faults lies solely on @bitschmidty

This time we do it in sets of 3
LN commitments carved using CPFP
Seeds encrypted when not running lightningd

Optech workshop materials, your homework
Taproot review responsibilities we should not shirk
New features of Bitcoin we get as a perk

@harding rocks the newsletter, shouldn't be strange
All I did was the StackExchange
Thanks @jonatack and @jnewbery for your things to change

@jnewbery jnewbery added the newsletters Publishing/translating/editing newsletters label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
newsletters Publishing/translating/editing newsletters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants