-
Notifications
You must be signed in to change notification settings - Fork 137
News: add 70 (2019-10-30) #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good short newsletter this week! Only one nit inline. Otherwise ACK.
## News | ||
|
||
- **LN simplified commitments:** in two separate threads, developers | ||
from LND discussed their work on implementing simplified commitments, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'developers from Lightning Labs' or 'developers of LND' (Lightning Labs is the company, LND the product)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an important distinction, thank you for mentioning it. I'll edit.
Pushed edit for @jnewbery feedback (thanks!), added a bullet for the Optech schnorr/taproot workshop, and added a short sentence and link to the PR for the LN simplified commitment previously described. |
notebooks, GitHub repositories, and more information produced for the | ||
schnorr and taproot workshops held in San Francisco and New York | ||
City last month. These explain the fundamentals of both proposals, | ||
guide students though actually using them, and then describe strategies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/students though/students through/
One typo, otherwise ACK 19d5e93 |
19d5e93
to
b6886ac
Compare
Rebased on master to pull in the schnorr/taproot blog post, updated link to point to it, added C-Lightning release, and fixed typo identified by @jnewbery (thanks!). All FIXMEs fixed now, so this should pass tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK b6886ac
and allows you keep your HD wallet seed encrypted when `lightningd` | ||
isn't running---plus many other features and several bug fixes. | ||
|
||
- **Help Bitcoin Core release candidate:** experienced users are encouraged to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 'Help test Bitcoin Core release candidate'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Perhaps "Help test the Bitcoin Core release candidate:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent and interesting newsletter! One typo (PostgreSQL) and a few nits below. I did not verify the links at the bottom. Cheers.
## Action items | ||
|
||
- **Upgrade to C-Lightning 0.7.3:** this latest [release][c-lightning | ||
0.7.3] adds support for a PostgresSQL backend, makes it possible to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/PostgresSQL/PostgreSQL/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly worth mentioning "in addition to SQLite3" (IIRC)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. A note for anyone else reviewing: this is wrong in the C-Lightning release notes; I checked that the spelling @jonatack proposes is the same as being used by the upstream PostgreSQL project.
|
||
- **Help Bitcoin Core release candidate:** experienced users are encouraged to | ||
help test the latest release candidates for the upcoming version of | ||
[Bitcoin Core][Bitcoin Core 0.19.0]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps provide a link to the testing meta-issue for test reports (or filing a separate issue in case of problems found).
|
||
## News | ||
|
||
- **LN simplified commitments:** in two separate threads, developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly s/threads/mailing list threads (or) lightning-dev mailing list threads/
LN protocol specification. | ||
|
||
- **Publication of videos and study material from schnorr/taproot workshop:** | ||
Optech published a [blog post][taproot workshop] with links to videos, Jupyter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: sometimes Optech writes "jupyter" and other times "Jupyter"... possibly a candidate for the style guide
|
||
- [Why does hashing public keys not actually provide any quantum resistance?]({{bse}}91049) | ||
Andrew Chow lists several considerations regarding public keys and quantum | ||
resistance including: needing to reveal the public key during spending, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits: add a comma after "resistance", remove the colon, and s/needing/the need/
branch and will probably not be released until version 0.20, expected | ||
about six months from now. BIP70 was made optional in [version | ||
0.18.0][core 0.18.0] and will be disabled by default in the upcoming | ||
0.19.0, see [Newsletter #19][pr14451] for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/, see/. See (or) ; see/
ACK |
Pushed (hopefully) final edits based on @jnewbery and @jonatack feedback (thanks). I split the edits into two commits to make it easier to squash this down into separate commits for the newsletter text added by @bitschmidty and for the text added by myself. |
help test the latest release candidates for the upcoming version of | ||
[Bitcoin Core][Bitcoin Core 0.19.0]. | ||
[Bitcoin Core][Bitcoin Core 0.19.0] and [report][Bitcoin Core #17079] | ||
any issues you find. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you want to get into the details, but what is desired afaict is for people to report their RC testing in the meta-issue (to reassure the maintainers that testing is taking place and for which platforms) and to open a separate issue if a problem is encountered while testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's confusing. I'm going to drop mention of this issue.
c413436
to
125eb9f
Compare
ACK 125eb9f |
Oh what a pity This time we do it in sets of 3 Optech workshop materials, your homework @harding rocks the newsletter, shouldn't be strange |
No description provided.