Skip to content

Topics: add new topics (bitschmidty) #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

harding
Copy link
Collaborator

@harding harding commented Oct 25, 2019

Eight proposed pages for the new /en/topics/ section of the site. Suggested reviewer is @bitschmidty

Note: tests expected to fail on the final "production" test because of the FIXME link pointing to a topic that's part of a different PR. That's the last test we run, so if it's the only failure, this should be ok.

Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jnewbery
Copy link
Contributor

jnewbery commented Oct 31, 2019

This is ready for merge once the v2 p2p transport topic is merged (#243)

@jnewbery jnewbery added the topics Topics indexes label Oct 31, 2019
@jnewbery jnewbery force-pushed the 2019-10-topics-bitschmidty branch from 8d20fab to 0201dbd Compare November 11, 2019 22:32
@jnewbery
Copy link
Contributor

rebased on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topics Topics indexes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants