Add schnorr/taproot workshop #241

jnewbery · 2019-10-22T20:19:07Z

Adds all the material from the schnorr/taproot workshops:

videos
slides
notebooks
link to transcipt

harding

A handful of nits (feel free to ignore). Since the images are just placeholders for the video files (thanks for doing that), I think their resolution could be lowered dramatically without any loss of effectiveness so that we're not adding 10 MB to the repository size with this commit (still, I don't care that much).

Thanks for creating this post and to everyone for all the work that went into the workshop!

harding · 2019-10-22T23:31:31Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+---
+{% include references.md %}
+
+In September 2019, Bitcoin Optech organized two workshops in San Francisco and


Nit: "two workshops in SF and NYC" sounds to me like you did two in SF and two in NYC. Maybe just drop the word "two"?

Also, I believe the name of the state is New York and the name of the city is New York City; however, I defer to your choice as someone living there. By now you probably pronounce it "Neh Yark" anyway.

harding · 2019-10-22T23:33:41Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+{% include references.md %}
+
+In September 2019, Bitcoin Optech organized two workshops in San Francisco and
+New York on the schnorr/taproot softfork proposals. The aims of the workshop


Nit: I think "workshop" should either be plural or should grouped ("each workshop").

harding · 2019-10-22T23:35:49Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+New York on the schnorr/taproot softfork proposals. The aims of the workshop
+were to:
+
+1. share current thinking in the open source community on the proposals;


Nit: s/on/about/ (generally we're interested in what people are thinking about, not what they're thinking on (especially if they're thinking on the toilet))

harding · 2019-10-22T23:36:50Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+those workshops, so engineers at home can learn about these exciting new
+technologies.
+
+The workshop is split into 4 sections:


s/workshop/workshops/ and s/is/was/ ?

harding · 2019-10-22T23:44:40Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+
+John Newbery introduces the workshop, giving a summary of why schorr and
+taproot are useful technologies. He also explains why Bitcoin Optech created
+the workshop, and what the aims of the workshop are.


Nit: no comma. The usual rule for a non-list comma preceding a conjunction are only to use the comma if the following phrase is an independent clause (e.g. it could be its own sentence). "What the aims of the workshop are" doesn't pass that test.

Yep. Thanks. This was vestigial from before I split this into two sentences.

harding · 2019-10-22T23:48:49Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+[![Introduction to Taproot](/img/posts/taproot-workshop/taproot-intro.png)](https://www.youtube.com/watch?v=KLNH0ttpdFg&list=PLPrDsP88ifOVTEJf_jQGunDUS05M9GdIC&index=5)
+{:.center}
+
+James Chiang gives an overview of the bip-taproot/bip-tapscript proposals. This


Nit: previously you've written "bip-taproot and bip-tapscript" but here you use only a slash to separate them; maybe use "and" for consistency? (This is definitely a do-as-I-say-and-not-as-I-do advice, since I'm lazy/use slashes all the time.)

harding · 2019-10-22T23:55:02Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+#### 2.2 Taptweak
+
+[![Taptweak](/img/posts/taproot-workshop/taptweak.png)](https://www.youtube.com/watch?v=EkGbPxAExdQ&list=PLPrDsP88ifOVTEJf_jQGunDUS05M9GdIC&index=7)
+{:.center}


No comment here, just a rouge meme.

@harding, what is a rouge meme?

"Rouge meme (n): a meme that has been pasted somewhere you don't normally paste memes, such as GitHub review comments" ---Harding's Dictionary of Made-Up Terms, 17th edition

harding · 2019-10-22T23:57:27Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+#### 2.5 Huffman Construction
+
+_(No video)_ This bonus chapter shows how to most efficiently construct a tree
+of scripts, by placing scripts that are more likely to be spent closer to the


Nit: no comma

Agree with @harding on the comma here

jonatack

A few fixes and nits. Looking forward to going through these workshops!

jonatack · 2019-10-23T16:15:32Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+  up the jupyter notebook environment, gives a refresher on basic elliptic
+  curve math, and introduces tagged hashes.
+2. [Schnorr signatures and MuSig](#schnorr-signatures-and-musig) - describes
+  the bip-schnorr signature scheme, and how to use MuSig to aggregate multiple


nit: remove the comma here as the second clause isn't a proper sentence/independent clause.

jonatack · 2019-10-23T16:16:26Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+2. [Schnorr signatures and MuSig](#schnorr-signatures-and-musig) - describes
+  the bip-schnorr signature scheme, and how to use MuSig to aggregate multiple
+  public keys and partial signatures into a single pubkey/signature.
+3. [Taproot](#taproot) - explains how to embed a commitment to a single script


s/to/into/ ?

"embed to" seems incorrect

The to here is attached to the commitment ('a commitment to'). The into later in sentence belongs to the embed ('explains how to embed ... into a tweaked public key'). I agree that the sentence isn't very clear. I've tried shifting it around a bit. Let me know if you think that's an improvement.

Thanks @jnewbery, I think the new version is much better.

jonatack · 2019-10-23T16:17:47Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+[![Introduction](/img/posts/taproot-workshop/introduction.png)](https://www.youtube.com/watch?v=1gRCVLgkyAE&list=PLPrDsP88ifOVTEJf_jQGunDUS05M9GdIC)
+{:.center}
+
+John Newbery introduces the workshop, giving a summary of why schorr and


s/schorr/schnorr/

jonatack · 2019-10-23T16:18:52Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+
+## Preparation and Basic Math
+
+This section shows how to setup the jupyter notebook, gives a refresher on


s/setup/set up/

"setup" is a noun, "set up" is the verb

jonatack · 2019-10-23T16:20:41Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+[![Introduction](/img/posts/taproot-workshop/elliptic-curve-math.png)](https://www.youtube.com/watch?v=oix8ov9iGgk&list=PLPrDsP88ifOVTEJf_jQGunDUS05M9GdIC&index=2)
+{:.center}
+
+Elichai Turkel gives a refresher on the basic elliptic curve math that will be


The word "gives" is used repeatedly. Consider varying, for instance with "provides".

jonatack · 2019-10-23T16:27:24Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+[![Tapscript](/img/posts/taproot-workshop/tapscript.png)](https://www.youtube.com/watch?v=nXGe9_M5pjk&list=PLPrDsP88ifOVTEJf_jQGunDUS05M9GdIC&index=8)
+{:.center}
+
+James shows how using a taptweak, we can commit a tapscript in a segwit v1


idem re "shows"

"taptweak" could be read as tapt weak or tap tweak, perhaps separate the two words unless this is an established word?

we use taptweak throughout the workshop (and it's used in bip-taproot as a hash tag: https://github.com/sipa/bips/blob/bip-schnorr/bip-taproot.mediawiki)

yes, I find "TapTweak" in the BIP to be clearer with the capital letters separation

Our style guide states that taproot is a common noun and uncapitalized. For consistency, we therefore use tapscript, taptree, taptweak, etc.

jonatack · 2019-10-23T16:28:38Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+{:.center}
+
+James shows how a merkle tree of scripts can be constructed, and how we can
+commit that tree using a taptweak. He then shows how to spend the output by


idem re shows and taptweak

jonatack · 2019-10-23T16:29:09Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+#### 2.5 Huffman Construction
+
+_(No video)_ This bonus chapter shows how to most efficiently construct a tree
+of scripts, by placing scripts that are more likely to be spent closer to the


Agree with @harding on the comma here

jonatack · 2019-10-23T16:30:26Z

workshops.md

-presentations, coding exercises and discussions, and will give engineers at
+functionality.
+
+Bitcoin Optech hosted two seminar format workshops whichi included a mixture of


s/whichi/which/

jonatack · 2019-10-23T16:31:42Z

workshops.md

 member companies an understanding of how these new technologies work and how
-they can be applied to their products and services. They will also give
+they can be applied to their products and services. The workshops also gave


perhaps "provided" to not write "gave" twice in the same paragraph

kanzure · 2019-10-23T16:41:49Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+community feedback process for these proposals.
+
+[slides]: /img/posts/taproot-workshop/taproot-workshop.pdf
+[transcript]: http://diyhpl.us/wiki/transcripts/bitcoinops/schnorr-taproot-workshop-2019/notes/


https on this link please and thank you

FYI, you could probably setup an automatically http→https redirect on your server. The reason I (and it seems others) keep using http is because that's the URL we copied/pasted while viewing the transcript.

jnewbery · 2019-10-23T18:43:04Z

Addressed all comments from @harding @jonatack @kanzure . Thanks for the reviews!

jonatack

Quick re-read.

jonatack · 2019-10-23T18:50:46Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

-  or multiple scripts into a tweaked public key. Shows how to spend a segwit v1
-  output using either the key path spend (with a single signature) or a script
-  path spend.
+3. [Taproot](#taproot) - demostrates how to create and then spend a segwit v1 output


s/demostrates/demonstrates/

jonatack · 2019-10-23T18:57:39Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

 taproot are useful technologies. He also explains why Bitcoin Optech created
-the workshop, and what the aims of the workshop are.
+the workshop and what the aims of the workshop are.


Nit: I think this sentence could be improved further. Workshop is used redundantly and the sentence ends a bit inelegantly with "and what the aims of the workshop are."

Perhaps: "He then outlines the workshop's aims" (or goals).

jonatack · 2019-10-23T18:58:31Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

@@ -116,7 +117,7 @@ scripts.
 [![Introduction to Taproot](/img/posts/taproot-workshop/taproot-intro.png)](https://www.youtube.com/watch?v=KLNH0ttpdFg&list=PLPrDsP88ifOVTEJf_jQGunDUS05M9GdIC&index=5)
 {:.center}

-James Chiang gives an overview of the bip-taproot/bip-tapscript proposals. This
+James Chiang gives an overview of the bip-taproot and bip-tapscript proposals. This


Nice -- much better with the "and" here.

jnewbery · 2019-10-23T19:30:30Z

Added a new commit to reduce image size (thanks for the suggestion @harding ). Obviously I'll squash that before merge to not bloat the repo.

jnewbery · 2019-10-23T19:35:23Z

addressed @jonatack's new review comments (thanks!)

harding · 2019-10-24T14:04:03Z

Tested ACK via the Netlify preview. I re-reviewed all text, clicked all links, and watched the first few seconds of each video to ensure they were the advertised content. Thanks!

bitschmidty

ACK

Thanks @jnewbery for putting this together

bitschmidty · 2019-10-28T18:39:20Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+New York City on the schnorr/taproot softfork proposals. The aims of the workshops
+were to:
+
+1. share current thinking in the open source community about the proposals;


Seems weird to me to end the list items with ; / .

changed to commas

bitschmidty · 2019-10-28T18:44:19Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+and explains why Bitcoin Optech created the workshop. He then outlines the
+workshop's aims.
+
+## Preparation and Basic Math


nit: lowercase basic math

bitschmidty · 2019-10-28T18:47:23Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+[![Segwit Version 1](/img/posts/taproot-workshop/segwit-version-1.png)](https://www.youtube.com/watch?v=n-jAUaSkcAA&list=PLPrDsP88ifOVTEJf_jQGunDUS05M9GdIC&index=6)
+{:.center}
+
+James shows how to create segwit version 1 transaction outputs and spend them


nit: version 1 here but v1 most elsewhere

bitschmidty · 2019-10-28T18:48:28Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+[![Tapscript](/img/posts/taproot-workshop/tapscript.png)](https://www.youtube.com/watch?v=nXGe9_M5pjk&list=PLPrDsP88ifOVTEJf_jQGunDUS05M9GdIC&index=8)
+{:.center}
+
+James discusses how using a taptweak, we can commit a tapscript in a segwit v1


s/how using a taptweak/how, using a taptweak,

rearranged the sentence

bitschmidty · 2019-10-28T19:38:24Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+{:.center}
+
+James shows how a merkle tree of scripts can be constructed, and how we can
+commit that tree using a taptweak. He then runs through how to spend the output by


s/commit that/commit to that

bitschmidty · 2019-10-28T19:55:55Z

_posts/en/2019-10-21-schnorr-taproot-workshop.md

+
+#### 2.0 Introduction to Taproot
+
+[![Introduction to Taproot](/img/posts/taproot-workshop/taproot-intro.png)](https://www.youtube.com/watch?v=KLNH0ttpdFg&list=PLPrDsP88ifOVTEJf_jQGunDUS05M9GdIC&index=5)


This video title should have (2.0) appended to it

the video doesn't actually correspond with notebook 2.0 (which was added after we ran the workshops). It's an introduction to all the 2.x topics.

jnewbery · 2019-10-28T20:25:24Z

squashed all commits: https://github.com/bitcoinops/bitcoinops.github.io/compare/d3e45c7d4b2819b60a3fac089b17b7fbf5219846..b1e617a9cd5eb97f03648674e42232bd75c2b97b. Will address @bitschmidty feedback next.

jnewbery · 2019-10-28T20:44:24Z

Addressed all feedback in @bitschmidty's review (thanks!). I plan to squash and merge tomorrow.

jnewbery · 2019-10-29T15:28:14Z

Squashed all commits, updated an image, and fixed the date.

jnewbery force-pushed the 2019-10-schnorr-taproot-workshop branch from 6c2c354 to c17ee03 Compare October 22, 2019 20:45

harding reviewed Oct 23, 2019

View reviewed changes

jonatack reviewed Oct 23, 2019

View reviewed changes

kanzure reviewed Oct 23, 2019

View reviewed changes

jonatack reviewed Oct 23, 2019

View reviewed changes

jnewbery force-pushed the 2019-10-schnorr-taproot-workshop branch from f8a55e7 to 1990a04 Compare October 23, 2019 19:29

bitschmidty reviewed Oct 28, 2019

View reviewed changes

jnewbery force-pushed the 2019-10-schnorr-taproot-workshop branch from d3e45c7 to b1e617a Compare October 28, 2019 20:25

jnewbery force-pushed the 2019-10-schnorr-taproot-workshop branch 2 times, most recently from 613fb2e to f952dc2 Compare October 29, 2019 15:19

Add schnorr/taproot workshop

f84798f

jnewbery force-pushed the 2019-10-schnorr-taproot-workshop branch from f952dc2 to f84798f Compare October 29, 2019 15:27

jnewbery merged commit eefc7aa into bitcoinops:master Oct 29, 2019

jnewbery deleted the 2019-10-schnorr-taproot-workshop branch October 29, 2019 15:51

cryptozyu pushed a commit to cryptozyu/bitcoinops.github.io that referenced this pull request Mar 20, 2023

Bitcoin Optech Newsletter bitcoinops#241

eaf4251

murchandamus mentioned this pull request Jul 17, 2023

Newsletter 257 translate in french #1182

Merged

murchandamus mentioned this pull request Aug 1, 2023

Harmonize titles of French Newsletters #1222

Merged


		## Preparation and Basic Math

		This section shows how to setup the jupyter notebook, gives a refresher on


		#### 2.0 Introduction to Taproot

		[![Introduction to Taproot](/img/posts/taproot-workshop/taproot-intro.png)](https://www.youtube.com/watch?v=KLNH0ttpdFg&list=PLPrDsP88ifOVTEJf_jQGunDUS05M9GdIC&index=5)

Add schnorr/taproot workshop #241

Add schnorr/taproot workshop #241

Uh oh!

Conversation

jnewbery commented Oct 22, 2019

Uh oh!

harding left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jachiang Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonatack Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonatack Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jachiang Oct 23, 2019 •

edited

Loading

jonatack Oct 23, 2019 •

edited

Loading

jonatack Oct 23, 2019 •

edited

Loading

jonatack Oct 23, 2019 •

edited

Loading