Skip to content

feat(pt): add scaffolding for Portuguese and #357 translation #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

luisschwab
Copy link

No description provided.

Copy link

@lucasbalieiro lucasbalieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, this looks like a good translation.

just a few minor nits.

I'm a bit unsure about translating certain context-specific terms like witness. might be worth discussing whether they should stay as-is.

Copy link
Collaborator

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool initiative!

I think most other translations only translate the newsletter, and you might find that translating the topic pages is a big additional burden, so perhaps you would want to first aim for a smaller goal and then expand later if you find you have the energy for it.

@tulio-albuquerque
Copy link

I'm a bit unsure about translating certain context-specific terms like witness. might be worth discussing whether they should stay as-is.

I think it's better to keep it as-is as it's used as a technical term.

@murchandamus
Copy link
Collaborator

For the German translation, we have a file to collate decisions on which terms are not translated and how terms are translated to be consistent across different newsletters. Something like that might also work well for you.

@tulio-albuquerque
Copy link

@murchandamus I created an initial portuguese version to but I'm failing to push it to this repo.

@tulio-albuquerque
Copy link

maybe this PR should be broken in two so that other people can start to contribute with translations with initial configuration to Portuguese already in place.

@luisschwab
Copy link
Author

you might find that translating the topic pages is a big additional burden, so perhaps you would want to first aim for a smaller goal and then expand later if you find you have the energy for it.

True, I just replicated the english scaffolding. I'll remove it for now, if someone wants to translate that they can add it later.

@luisschwab luisschwab force-pushed the feat/pt-and-357 branch 2 times, most recently from 41cbae5 to 44c15e9 Compare June 9, 2025 21:02
@luisschwab
Copy link
Author

maybe this PR should be broken in two so that other people can start to contribute with translations with initial configuration to Portuguese already in place.

Why would we do that? When this gets merged you can build on top of this PR.

@tulio-albuquerque
Copy link

tulio-albuquerque commented Jun 9, 2025

maybe this PR should be broken in two so that other people can start to contribute with translations with initial configuration to Portuguese already in place.

Why would we do that? When this gets merged you can build on top of this PR.

Usually it's one feature per PR and I don't know long it would take to this PR to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants