-
Notifications
You must be signed in to change notification settings - Fork 137
Newsletters: add 66 (2019-10-02) #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Only one comment inline.
- [LND #3523][] allows users to update the maximum millisat value of | ||
HTLCs they'll accept in a particular open channel or across all of | ||
their open channels. Any updates will be communicated to the channel | ||
peer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this last sentence is a little confusing. Channel updates are gossiped to all peers and relayed across the network, not just the individual channel peer.
[taproot][bip-taproot] soft fork. We thank Bryan Bishop for typing an | ||
excellent [transcript][workshop transcript] of the NYC workshop. We | ||
are preparing videos and other educational material for release via a | ||
blog post in the near future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to link to https://github.com/bitcoinops/taproot-workshop or save this for the upcoming blog post?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think save it. Let's release/announce all the material at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @harding. A few nits; feel free to pick and choose. I verified the links at the end and they LGTM.
lang: en | ||
--- | ||
This week's newsletter notes a proposed BIP that would allow nodes to | ||
implement the erlay transaction relay protocol, announces full |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit regarding "erlay" here, and the two other cases in this newsletter: the authors call it "Erlay" in their paper last June (https://arxiv.org/pdf/1905.10518.pdf) and git grepping this repo returns only "Erlay" and no other instances of "erlay"
implement the erlay transaction relay protocol, announces full | ||
disclosure of vulnerabilities that affected earlier versions of LN | ||
implementations, and links to a transcript of Optech's recent schnorr | ||
and taproot workshop. Also included is the description of several |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/workshop/workshops/?
recent release. At that time, they strongly encouraged their users to | ||
upgrade (a message which Optech [relayed][optech ln warning]) and | ||
promised a full disclosure in the future, which they have now done | ||
with a [email][russell disclosure] by vulnerability discoverer and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/a email/an email/
C-Lightning developer Rusty Russell and a [blog post][lnd stay safe] | ||
by LND developers Olaoluwa Osuntokun and Conner Fromknecht. | ||
|
||
Briefly, the issue appears to have been that implementations did not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing "the" between "that" and "implementations"
confirm that channel open transactions paid the correct script, | ||
amount, or both. Because of this, the implementations would accept | ||
payments within the channel which they would later be unable to get | ||
confirmed onchain, allow them to be defrauded. As of this writing, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/allow/allowing/?
|
||
## News | ||
|
||
- **Draft BIP for enabling erlay compatibility:** a draft [BIP for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps mention the BIP's title, "Transaction announcements reconciliation"
[libsecp256k1][libsecp256k1 repo], [Bitcoin Improvement Proposals | ||
(BIPs)][bips repo], and [Lightning BOLTs][bolts repo].* | ||
|
||
- [Bitcoin Core #15558][] changes the number of DNS seeds Bitcoin Core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: interesting how much discussion this PR got, and ajtowns' post-merge review suspecting a bug. Might be a good review club PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
been disclosed, a [PR][BOLTS #676] has been opened to update the | ||
specification to note that this check is needed. | ||
|
||
- **Optech taproot workshop:** last week, Optech held workshops in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Half the workshop was on schnorr so perhaps its more accurate to title as 'Optech schnorr and taproot workshop'
This merge causes Bitcoin Core to only query three DNS seeds at a | ||
time rather than all of them. Three seeds should be enough | ||
diversity in sources to ensure the node connects to at least one | ||
honest peer (a requirement for Bitcoin security) but it's few enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security) but -> security), but
bandwidth inefficient for Bitcoin's tens of thousands of nodes and | ||
several hundred thousand transactions a day. As [described | ||
previously][erlay paper], minisketch-based set reconciliation allows | ||
nodes to instead send a *sketch* of a set of txids that can be combined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: to instead send -> to send (split infinitive and instead doesn't add extra meaning.)
0e7a8a6
to
35cf370
Compare
Updated with BTSE report and to address feedback (thanks!). |
--- | ||
title: 'Field Report: Exchange operation using Bitcoin technologies at BTSE' | ||
permalink: /en/btse-exchange-operation/ | ||
name: 2019-10-??-btse-exchange-operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TO FIX
35cf370
to
e9751c0
Compare
Made the changes suggested in #230 (review) and squashed. |
e9751c0
to
93a34a1
Compare
I noticed that 2 of the links in the field report were absolute so I corrected those to relative (which required adding one of them to the references.md) |
Last week we had the Optech workshop BTSE reports on using bitcoin tech Erlay suggests efficiency/bandwidth mix @harding Thanks for a great newsletter with @dongcarl hard work with boots on the ground field reporting! TY to @moneyball @jnewbery @jonatack @adamjonas for reviews |
No description provided.