-
Notifications
You must be signed in to change notification settings - Fork 137
Update ruby version & re-activate schema checker #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ruby version & re-activate schema checker #224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 14f0d60, Ruby 2.6.4 is the current latest stable version of Ruby. Using my current install of ruby 2.6.4p104 (2019-08-28 revision 67798) [x86_64-linux] packaged with rbenv (a simpler rubies version manager that I switched to a few years ago after many years using rvm), along with rubygems version 3.0.3, I git cloned this repo, ran 'make' and 'make preview' and navigated a few pages the site in the browser. OTOH make test
returns "make: *** No rule to make target 'test'. Stop." I did not perform a diff test, only a fresh build and run.
|
||
BUNDLED WITH | ||
1.16.6 | ||
1.17.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest upgrading bundler as well:
~/projects/bitcoin/bitcoinops.github.io (pr/224)$ gem install bundler
Fetching bundler-2.0.2.gem
Successfully installed bundler-2.0.2
Parsing documentation for bundler-2.0.2
Installing ri documentation for bundler-2.0.2
Done installing documentation for bundler after 2 seconds
1 gem installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to leave that for later. This PR resolves a problem we had, but subsequent to it getting merged, I plan to PR an update to the latest version of Jekyll that will update almost all of our dependencies. To me, that seems like the correct time to update bundler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundler is the dependencies resolver/package manager, so I tend to update it before running any bundle
commands like here. If helpful, I'm on the latest and had no issues with the deps when bundle installing, but as long as you're not seeing any issues then either way should be fine.
For info, Ruby 2.7.0 will be released around Christmas time as per the Ruby major release tradition. |
14f0d60
to
f8eff5a
Compare
Removed |
tACK f8eff5a |
This upgrades the version of Ruby used by the site-building tools to 2.6.4, which is listed as the latest stable version on https://www.ruby-lang.org/en/downloads/ . It also re-enables the schema checker that was part of #168 but removed in #174 due to an incompatibility between the Gemfile and the Netlify preview and deployment scripts. (I still don't know what the specific problem was, but upgrading Ruby fixes it in my tests.)
If you've previously installed Ruby (e.g. per our README.md), you will need to install the latest version of Ruby. If you followed the README's previous install instructions to use rvm, you can do this with a single command:
After it's installed, rvm will automatically select the correct ruby when you enter the repository top-level directory (if you're already in the directory when the ruby version changes, you can use
cd .
to switch).This change in ruby versions should not produce any meaningful content differences in the site, so the testing procedure I recommend is:
For me, the new ruby caused a bunch of JSON associative arrays to have a different sort order, which is annoying to scan through but not a functional change. All other content was unaffected.
Note: normally I'd upgrade Ruby in a separate PR from adding dependencies (the revert commit) but I think it's better to do both together here to ensure upgrading Ruby truly eliminates the dependency problem.
My thanks to @schmidty for making the Netlify build logs public.