-
Notifications
You must be signed in to change notification settings - Fork 137
Newsletters: add 62 (2019-09-04) #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9aa2e30
to
f91f3d9
Compare
I merged #218 and rebased this on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks @harding . Three small comments inline.
to be disclosed at the end of this month affect older LN | ||
implementations. If you are using any of the following software | ||
versions, upgrading to a more recent version is [strongly | ||
recommended:][cve ln] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit: anchor around strongly recommended
, not strongly recommended:
[cve ln]: https://lists.linuxfoundation.org/pipermail/lightning-dev/2019-August/002130.html | ||
[bolts608]: /en/newsletters/2019/08/28/#bolts-608 | ||
[bolts]: https://github.com/lightningnetwork/lightning-rfc/ | ||
[snicker]: https://gist.github.com/AdamISZ/2c13fb5819bd469ca318156e2cf25d79#storage-of-keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this linking to the #storage-of-keys
id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a mistake (I grabbed that link for a separate discussion about that aspect of the proposal and then reused it here without thinking about it). Thanks to you and @jonatack for catching this, I'll fix it.
|
||
## News | ||
|
||
- **SNICKER proposed:** Adam Gibson posted to the Bitcoin-Dev mailing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we link to the mailing list post (https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-September/017283.html) as well as the draft BIP.
I also think we could link to Adam's blog post (https://joinmarket.me/blog/blog/snicker/)
as described in [last week's newsletter][bolts608]. | ||
|
||
- [Eclair #899][] implements extended queries as proposed in [BOLTs | ||
#557][], allowing an LN node to only request gossip updates that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: to only request -> only to request (split infinitive)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting newsletter as always and great to see Adam Gibson's proposal discussed! A few comments below.
--- | ||
This week's newsletter relays a security announcement for LN | ||
implementations, describes a non-interactive coinjoin proposal, and | ||
notes a few changes in popular Bitcoin Infrastructure projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: lowercase "infrastructure"
lang: en | ||
--- | ||
This week's newsletter relays a security announcement for LN | ||
implementations, describes a non-interactive coinjoin proposal, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proposed to Adam to drop by and have a look-see
also be able to derive from Alice's public key. With the shared | ||
secret and Bob's public key, Alice is able to create a new public key | ||
that only Bob can sign for. That new public key is used to create the | ||
new address for Bob's coinjoin output. Nobody besides Alice and Bob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: s/Nobody/No one/
both possibilities.-->{% endcomment %} | ||
|
||
With information about the inputs and the outputs, Alice creates a | ||
[BIP174][] Partially-Signed Bitcoin Transaction (PSBT) containing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each time I read "Partially-Signed..." it strikes me as a (minor, perhaps pedantic) grammar error. "Partially" can only be an adverb. IIUC, dashes are only appended to adverbs when they can also be adjectives (or other), to clarify when they play the part of an adverb and modify the word they precede.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave this as-is since I have a busy todo list today and we've used this construction many times before, but tomorrow I'll look into this in more detail and will either get back to you with an explanation or will open a PR to remove the hyphen across the repository. (Omitting the hyphen feels wrong to me and I have a vague recollection of a rule requiring (or at least suggesting) it, but I need to research it.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyphens, thank you. As a recovering liberal hyphenizer before coming across the rule I mentioned, I'm interested in your conclusion. Could imagine a possible exception to the rule for titles or proper nouns.
- **SNICKER proposed:** Adam Gibson posted to the Bitcoin-Dev mailing | ||
list with a [proposal][snicker] for *Simple Non-Interactive Coinjoin | ||
with Keys for Encryption Reused* (SNICKER), a two-step method for | ||
allowing wallets to create coinjoins non-interactively. In the first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: name the two steps (proposal/reception) before launching into the detail about each one
This completes the proposer step in SNICKER. | ||
|
||
If Bob participates in the scheme, his wallet can begin the second | ||
step (*receiver* step) by periodically checking the server to see if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps: s/receiver step/reception/
SNICKER exchange server. | ||
|
||
The main downside of the proposal is that it requires the proposer | ||
(Alice) know the public key of the receiver (Bob). Almost all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: s/know/to know/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively, s/requires the/requires that the/
The main downside of the proposal is that it requires the proposer | ||
(Alice) know the public key of the receiver (Bob). Almost all | ||
transactions today pay an address that doesn't include a public key, | ||
although that may to change if the proposed [taproot][bip-taproot] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/may to change/may change/
transactions today pay an address that doesn't include a public key, | ||
although that may to change if the proposed [taproot][bip-taproot] | ||
soft fork is activated and becomes widely adopted. In the meantime, | ||
the SNICKER proposal suggests using reused addresses where public keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: s/using reusing addresses where/reusing addresses whose/
[cve ln]: https://lists.linuxfoundation.org/pipermail/lightning-dev/2019-August/002130.html | ||
[bolts608]: /en/newsletters/2019/08/28/#bolts-608 | ||
[bolts]: https://github.com/lightningnetwork/lightning-rfc/ | ||
[snicker]: https://gist.github.com/AdamISZ/2c13fb5819bd469ca318156e2cf25d79#storage-of-keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the #storage-of-keys part of this URL desired? IIUC the link is used in the intro sentence "Adam Gibson posted to the Bitcoin-Dev mailing list with a [proposal][snicker] for Simple Non-Interactive Coinjoin with Keys for Encryption Reused"...
Had a quick read through, it's a very good concise summary of the main idea, better than either that of mine, probably. "map of addresses and public keys" - I think using the term 'map' here is a bit suboptimal in terms of understanding for the reader. Maybe better something like 'scans the blockchain to make lists of candidate public keys, either from reused addresses or from inferring connections between inputs an outputs, or perhaps via some watermarking in transactions'. Or ... a shorter version of that, if you prefer :) I agree with your de-emphasis of encryption here ('perhaps encrypted') given our earlier conversation. Perhaps 'perhaps' is too faint though :) But no worries, that's fine. But one last point - I do think the use of anonymous network connections to the server should probably be mentioned. Just because it serves to further emphasize that the "bulletin board" server is just that; identities or accounts are not involved, at least not within the proposal as-is. Thanks for writing this @harding and thanks for the ping @jonatack ! |
Pushed edits for feedback. Thanks everyone for the reviews! |
If Bob participates in the scheme, his wallet can begin the second | ||
step (*receiver* step) by periodically checking the server to see if | ||
If Bob participates in the scheme, his wallet can begin the | ||
receiver by periodically checking the server to see if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/receiver/receiver step/ ?
This completes the proposer step in SNICKER. | ||
|
||
If Bob participates in the scheme, his wallet can begin the | ||
receiver by periodically checking the server to see if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/begin the receiver/begin the receiver step/
people via a variety of servers, selecting whichever proposal he | ||
prefers (or none at all). Either party can also spend their UTXO | ||
normally at any time, automatically invalidating any pending proposals | ||
without any harm done. The PSBTs can be exchanged using any medium that doesn't require users identify themselves, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/doesn't require users identify/doesn't require users to identify/
|
||
The main downside of the proposal is that it requires the proposer | ||
(Alice) know the public key of the receiver (Bob). Almost all | ||
transactions today pay an address that doesn't include a public key, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps: almost all transactions outputs today pay to an address
SNICKER exchange server. | ||
|
||
The main downside of the proposal is that it requires the proposer | ||
(Alice) know the public key of the receiver (Bob). Almost all | ||
transactions today pay an address that doesn't include a public key, | ||
although that may to change if the proposed [taproot][bip-taproot] | ||
although that may change if the proposed [taproot][bip-taproot] | ||
soft fork is activated and becomes widely adopted. In the meantime, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that here ("widely adopted") you did not use a hyphen 👼
Verified the new links are 🆗 |
in b4 @bitschmidty Takes a few steps to make a snicker newsletter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 17aa336
17aa336
to
016c3cc
Compare
my little ditty comments are getting redundant Adam Gibson on the mail list has spoken rebased, squashed and merged! thanks @harding and reviewers! |
Based on #218, ignore first commit#218 has been merged