Compatibility page tweaks #189
Conversation
For screenshots whose background matches our background, it can look like the image is truncated. E.g. the top of a mobile app with a button, long empty area matching our bachground, then bottom of the mobile app makes it look like two separate images. This commit adds a thin black border around the image to show that it's just one image.
|
@jnewbery I cherry picked @bitschmidty's commit. |
|
Pushed a commit that drops the colored underlining and replaces it with colored and styled bullet points (blue checkmark and yellow X, the same as in the table view, and a grey ≈ for neutral). Preview: https://deploy-preview-189--bitcoinops.netlify.com/en/compatibility/bitcoin-core/ |
|
@harding I think that looks really great. Easier to see wrt colors and the icon reinforces it. |
|
Pushed a commit that removes the segwit v1 tests results from the compatibility templates. |
|
This looks great @harding. Big improvement. |
bitschmidty
force-pushed
the
2019-07-compat-tweaks-1
branch
from
1611403 to
cf6dcae
Compare
|
Added a commit that adds links to the RBF and segwit address sections to each detail page. |
harding
force-pushed
the
2019-07-compat-tweaks-1
branch
from
3a79a60 to
1263826
Compare
|
I have one issue with the compatibility: added more definition to 'Not tested' texts commit. I think the phrasing the statements in the affirmative (eg Not tested: notification notes RBF) could be confusing for someone skimming the page:
I've added a final commit that changes those affirmitive statements into questions (eg Does transaction notification show whether transaction signals RBF?):
@bitschmidty - does that change look good to you? If so, I'm happy to merge this PR. |
|
@jnewbery looks good, thanks for that! |
Here are a few small tweaks to the compatibility page CSS and generation code (not specific wallets). Individual commit comments describe the motivation when it's not obvious.