Skip to content

Newsletters: add #39 (2019-03-26) #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

harding
Copy link
Collaborator

@harding harding commented Mar 25, 2019

No description provided.

@@ -44,7 +44,6 @@ for details --> {% endcomment %}
{% comment %}<!-- Later link definitions supersede earlier definitions.
When more recent information about a BIP is available not in the regular
place, put links here. -->{% endcomment %}
[BIP151]: https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this gist previously pointed to the updated version of BIP151. However, now its latest HEAD points to the v2 encrypted protocol, so I've dropped it so that we link to the old version of BIP151 instead. An alternative would be for me to find the previous updated-151 version in the gist repository history (let me know if you want that; I have no preference here).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm indifferent


## News

- **Version 2 P2P transport proposal:** Jonas Schnelli sent a proposed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh, can't believe I forgot to put a link. I'm going to link to the mailing list thread because I want to encourage people to comment there for now. If we link to it in the future, we may use the gist (but hopefully he'll have a new BIP number by then).

@@ -44,7 +44,6 @@ for details --> {% endcomment %}
{% comment %}<!-- Later link definitions supersede earlier definitions.
When more recent information about a BIP is available not in the regular
place, put links here. -->{% endcomment %}
[BIP151]: https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm indifferent

trusted payment in advance of the trustless exchange as an act of
good faith and an assurance that the operation won't end up costing
Bob money.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this is referring to "Fee: Client sends a small fee HTLC that is unrestricted"? And, just to make sure I understand, this is an off-chain/LN payment from Alice to Bob?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'm editing to add "via LN" so that it's clearer. Thanks for catching that confusing omission!

To further gauge segwit popularity, you might also want to know which
notable Bitcoin wallets and services support it. For that, we recommend
the community-maintained [bech32 adoption][] page on the Bitcoin Wiki or
the [when segwit][] page maintained by BRD Wallet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lowercase wallet?

@moneyball
Copy link
Contributor

tACK


![Screenshot of Optech Dashboard segwit usage stats](/img/posts/2019-03-segwit-usage.png)

However, wallets supporting segwit can also receive payment to
Copy link
Contributor

@jnewbery jnewbery Mar 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this paragraph would be a little confusing for people not familiar with P2SH-wrapped segwit. Do you think the following would be clearer:

However, wallets supporting segwit can also receive payment to
backwards-compatible _P2SH-wrapped segwit_ addresses.  We can't directly track how many P2SH address are P2SH-wrapped segwit, but
the statistics sites linked earlier do tell us how often users spend
bitcoins they received to a P2SH-wrapped segwit address.  Currently, that
averages at about 37% of transactions.  If adoption remained steady at
that level, it would represent a minimum average of 1,400 outputs per
block.  Likely, it's even higher now.

I don't understand what you mean by '37% of transactions. Are you saying that 37% of spends are from P2SH-wrapped segwit UTXOs? Or that 37% of P2SH outputs that are spent are P2SH-wrapped segwit?

EDIT: harding has clarified this for me. 37% of inputs used in transactions are P2SH-wrapped segwit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I told @jnewbery wrong. It's that 37% of transactions contain at least one input that spends from a nested-segwit output.

I'll be editing the paragraph to try to improve clarity.

@moneyball
Copy link
Contributor

tACK a09d111

(RC) for the next major version of Bitcoin Core has been [released][0.18.0].
Testing is still needed by organizations and experienced users who
plan to run the new version of Bitcoin Core in production. Use [this
issue][Bitcoin Core #15555] for reporting feedback.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see this comment bitcoin/bitcoin#15555 (comment):

I'd advise against reporting issues here. They should go in their own report. Otherwise it is hard to follow-up on reports when everything is in the same thread.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @practicalswift! I think it still makes sense to point testers to a single location to 'leave feedback'. If they need to open an new issue for an unreported problem, that issue instructs them to do so.

Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a fixup commit with a few small changes. @harding - are you able to take a look before we publish?


![Screenshot of Optech Dashboard segwit usage stats](/img/posts/2019-03-segwit-usage.png)

However, many wallets want to use segwit but still need to deal with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll suggest a few additional changes to this paragraph in a commit.

(BIPs)][bips repo].*

- [Bitcoin Core #10973][] makes Bitcoin Core's built-in wallet access
information about the block chain through a class rather than using
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is clearer wit s/a class/a well-defined interface.

with this update, but the merge is notable because it's the last of a
set of foundational refactorings that should make it easy for
future changes to run the node and the wallet/GUI in separate
processes (see [Bitcoin Core #10102][] for one approach to this).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also improves code modularity and makes component testing easier.


- [Bitcoin Core #15617][] omits sending `addr` messages containing the
IP addresses of peers the node currently has on its ban-list. This
helps prevent innocent nodes from learning about peers your node found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the word 'innocent' a bit unsuitable in a p2p trustless network. Reworded in my fixup commit.

configuration option (default: 0.1 BTC). The new parameter takes a
feerate and will reject the transaction if its feerate is above the
provided value (regardless of the setting for `maxtxfee`). If no
value is provided, it'll only send the transaction if its feerate is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if its fee is below the maxtxfee total.

@harding
Copy link
Collaborator Author

harding commented Mar 26, 2019

Untested ACK 85d0e23 Thanks!

@jnewbery jnewbery force-pushed the 2019-03-26-newsletter branch from 85d0e23 to 8e02da4 Compare March 26, 2019 14:22
@jnewbery jnewbery merged commit e0283b1 into bitcoinops:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants