Meetings: add 2018-07-12 & 2018-07-19 #576

harding · 2018-07-13T19:30:27Z

Preview: http://dg0.dtrt.org/en/meetings/2018/07/12/

harding · 2018-07-20T20:03:42Z

Added 2018-07-19 meeting since previous meeting notes didn't have any reviews yet. Preview: http://dg0.dtrt.org/en/meetings/2018/07/19/

For the topic about Bitcoin.org, I wrote a background and conclusion section but for the discussion section, I just linked to the log. That's not a subject about which I can credibly summarize in a dispassionate manner. I think just linking to the log here is fine, but if someone else wants to write a summary of the discussion, I'd be happy to include it.

jnewbery

ACK 494c83d. A few nits/comments inline, but this is good to go as-is.

For the Bitcoin.org topic, I've made some suggestions to change the wording, but I'll also recuse myself from writing the detailed log 😛

jnewbery · 2018-07-22T15:53:49Z

_posts/en/meetings/2018-07-12-meeting.md

+Several meeting participants listed things they'd like to get in that
+they're worried won't be complete before the freeze:
+
+- [New `scantxout` RPC][#12196], mentioned by Jonas Schnelli


nit: The rendered link looks slightly odd. It's a matter of personal taste, but consider removing the backticks.

jnewbery · 2018-07-22T16:12:35Z

_posts/en/meetings/2018-07-19-meeting.md

+which of a user's bitcoins to spend in a particular transaction.  The
+selected *Unspent Transaction Outputs (UTXOs)*, often simply called
+*coins,* become *inputs* in the transaction.  Developers have spent many
+hours in the past year improving Bitcoin Core's coin selection to be


nit: many hours undersells this a bit! Many developer days or weeks would be closer to the mark.

jnewbery · 2018-07-22T16:21:38Z

_posts/en/meetings/2018-07-19-meeting.md

+[log coredev meet]: {{log}}#l-279
+
+[meet osd]: /en/meetings/2018/06/28/#output-script-descriptors
+[osd gist]: https://gist.github.com/sipa/e3d23d498c430bb601c5bca83523fa82


I sometimes worry that gists aren't stable links, since they feel more ephemeral. There's not really any alternative though, and better to link to this now and risk having it break in future than not link.

jnewbery · 2018-07-22T16:24:07Z

_posts/en/meetings/2018-07-19-meeting.md

+working for it.
+
+There are several seeder programs written by different authors.  One of
+them is maintained by Pieter Wuille and is simply called `bitcoin-seeder`. 


Add link to repo (https://github.com/sipa/bitcoin-seeder)?

jnewbery · 2018-07-22T16:34:52Z

_posts/en/meetings/2018-07-19-meeting.md

+
+## Moving away from Bitcoin.org
+
+**Background:** Since the 2009 release of the original Bitcoin software,


I think this is ok, but some of the conjunctions are perhaps a little loaded (But over time..., so Bitcoin Core began.., etc)

I've made an attempt at rewriting the section. Feel free to take or leave:

Background: Since the 2009 release of the original Bitcoin software, Bitcoin (and later Bitcoin Core) resources have been hosted on Bitcoin.org. Over time, this was augmented with additional resources about the increasingly diverse Bitcoin network.

In December 2015 Bitcoin Core began using its own domain to host its resources, and later also to host its software releases. Release announcements and software continue to be mirrored to Bitcoin.org.

Discussion: Andrew Chow introduced the topic by suggesting "moving away from Bitcoin.org". He added "we still link to bitcoin.org for things like downloads. [We] should probably change those". See the [log][log bco] for the full discussion. Some discussion also occurred [after the meeting][post-meeting bco].

Conclusion: No explicit conclusion. Post-meeting discussion seemed to indicate no significant changes to the current process.

Used this text verbatim except for two capitalization changes to match the style used elsewhere in the document. Thanks!

harding · 2018-07-23T14:42:40Z

Commit c5495d1 implements all improvements suggested by @jnewbery (thanks!). I plan to merge this later today, but am happy to delay if anyone else wants to review.

jnewbery

looks good. Sorry, I've added one more nit.

jnewbery · 2018-07-23T17:35:51Z

_posts/en/meetings/2018-07-12-meeting.md

+they're worried won't be complete before the freeze:
+
+- [New scantxout RPC][#12196], mentioned by Jonas Schnelli
+- [New `disableprivatekey` setting][#9662] for watching-only wallets,


Same feedback as the line above: remove backticks to avoid strange-looking link.

I fixed, squashed and force-pushed this to not delay the merge. Hope that's ok @harding!

(I assume so since you'd already done the same fix to the link above)

LGTM, thanks! I'll wait another couple hours until around 16:00 EDT in case anyone else wants to comment, then merge.

Includes some text about Bitcoin.org written by John Newbery

jnewbery · 2018-07-23T18:07:57Z

ACK 2df5496. Happy to have the fixup commit squashed (or not!)

maflcko · 2018-07-23T22:00:07Z

Could someone please create a singed merge commit of merge 1aa9649 7f12b8b?

Otherwise, this will not be shown on the website.

harding · 2018-07-23T23:12:22Z

@MarcoFalke do you know of a way to do that? I played around, I don't see a way to convince git to let me merge things that are already part of the tree.

This repository has its master branch protected against rewrites, so I can't reset to before the merge. The only way I know of to maybe fix this is to reset the trusted-git-root, which I'm reluctant to do and which may not work depending on how the build script works.

@laanwj @jonasschnelli @btcdrak maybe you have access to revert master to HEAD^ so that this can be re-merged properly? (Or another solution to suggest.)

Sorry for the miscommunication here.

maflcko · 2018-07-23T23:34:21Z

@harding untested gist:

git checkout 1aa9649
git merge 7f12b8b --no-ff -m 'Merge #576 (take 2)'
git commit --amend # Append Tree-SHA512
git push [email protected]:bitcoin-core/bitcoincore.org.git HEAD:master

maflcko · 2018-07-23T23:35:25Z

Note that the git push in my example does not use a -f.

Tree-SHA512: 2e1493b59570ef967f31ca605a1f336b976f287240c319b4c31357135b8b354afd6475820d201ca16f21502616676dc6f810ac6f707cc2f7c232bdc3190053f2

harding · 2018-07-24T00:01:06Z

@MarcoFalke many thanks, that worked. Unfortunately, the repo permissions are setup not to allow pushes without Approved reviews, so I had to open PR #580 and will have to wait for @jnewbery to Approve it. I think (and hope) I should then be able to merge it as a fast-forward and push it manually to get the intended effect.

harding · 2018-07-24T01:34:33Z

Everything appears to be fixed now. Thanks again, @MarcoFalke.

harding added 2 commits July 13, 2018 15:24

Meetings: add 2018-07-12

e14b402

Meetings: add 2018-07-19

494c83d

harding force-pushed the 2018-07-13-meeting branch from 7a4ef3c to 494c83d Compare July 20, 2018 19:58

harding changed the title ~~Meetings: add 2018-07-12~~ Meetings: add 2018-07-12 & 2018-07-19 Jul 21, 2018

harding mentioned this pull request Jul 21, 2018

Add newsletter #5 2018-07-24 bitcoinops/bitcoinops.github.io#40

Merged

jnewbery approved these changes Jul 22, 2018

View reviewed changes

jnewbery reviewed Jul 23, 2018

View reviewed changes

Meetings: minor improvements to 2018-07-12 and 2018-07-19

2df5496

Includes some text about Bitcoin.org written by John Newbery

jnewbery force-pushed the 2018-07-13-meeting branch from c5495d1 to 2df5496 Compare July 23, 2018 18:06

jnewbery merged commit 7f12b8b into bitcoin-core:master Jul 23, 2018

harding added a commit to harding/website that referenced this pull request Jul 23, 2018

Re-merge of bitcoin-core#576 to fix missing signature

f6d46c4

harding added a commit to harding/website that referenced this pull request Jul 23, 2018

Merge bitcoin-core#576 (take 2)

3e05471

Tree-SHA512: 2e1493b59570ef967f31ca605a1f336b976f287240c319b4c31357135b8b354afd6475820d201ca16f21502616676dc6f810ac6f707cc2f7c232bdc3190053f2

harding mentioned this pull request Jul 23, 2018

Fix failed build by re-merging with authorized signature #580

Merged


		## Moving away from Bitcoin.org

		Background: Since the 2009 release of the original Bitcoin software,

Meetings: add 2018-07-12 & 2018-07-19 #576

Meetings: add 2018-07-12 & 2018-07-19 #576

Uh oh!

Conversation

harding commented Jul 13, 2018

Uh oh!

harding commented Jul 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jnewbery left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harding commented Jul 23, 2018

Uh oh!

jnewbery left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jnewbery commented Jul 23, 2018

Uh oh!

maflcko commented Jul 23, 2018

Uh oh!

harding commented Jul 23, 2018

Uh oh!

maflcko commented Jul 23, 2018

Uh oh!

maflcko commented Jul 23, 2018

Uh oh!

harding commented Jul 24, 2018

Uh oh!

harding commented Jul 24, 2018

Uh oh!

Uh oh!

harding commented Jul 20, 2018 •

edited

Loading