Skip to content

Handle changed apply method. #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

Handle changed apply method. #773

merged 1 commit into from
May 18, 2022

Conversation

stephenbach
Copy link
Member

Changing the signature of apply() on eval-hackathon broke this test.

VictorSanh
VictorSanh approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@VictorSanh VictorSanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this! lgtm!

@stephenbach stephenbach merged commit 9dcd89e into eval-hackathon May 18, 2022
@stephenbach stephenbach deleted the fix_eval_test branch May 18, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorSanh VictorSanh VictorSanh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenbach @VictorSanh