-
Notifications
You must be signed in to change notification settings - Fork 365
Add GEM/xsum prompts #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GEM/xsum prompts #745
Conversation
@awebson from an engineering perspective do we have to copy these directly or could we pull from https://huggingface.co/datasets/xsum as is? |
There is actually a slight difference in that https://huggingface.co/datasets/xsum uses 'summary' as a key for the summary text, while GEM/xsum uses 'target' as a key. So the prompts written for GEM/xsum reflect that difference. e.g.
instead of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup what Ken did is correct. We need to copy the old xsum prompts to gem/xsum and make necessary changes. Merging now since the xsum prompts were already approved. Thanks!
@@ -26,7 +26,7 @@ | |||
|
|||
# These are users whose datasets should be included in the results returned by | |||
# filter_english_datasets (regardless of their metadata) | |||
INCLUDED_USERS = {"Zaid", "craffel"} | |||
INCLUDED_USERS = {"Zaid", "craffel", "GEM"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INCLUDED_USERS = {"Zaid", "craffel", "GEM"} | |
INCLUDED_USERS = {"Zaid", "craffel", "GEM"} |
@kkawamu1 Looks like taking out the hack broke automatic tests :( And I somehow I don't have permission to commit a fix from my end. Can you re-add |
@awebson Should be updated! i.e. GEM is added back to INCLUDED_USERS now! |
Add 10 prompts for GEM/xsum.
All the prompts are taken from the prompts already implemented for https://huggingface.co/datasets/xsum in the host version promptsource.