Enable Flag from ENV Var #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update allows for control of if you want to enable the Server Timing Header Response. I think this should be something included out of the box, I know its a simple change but its something that I think I helpful as lots of things are controlled via ENV vars in the end. I have it reading the ENV Value and checking if its string(true), if so then true otherwise false. If no value is passed in then it defaults to true anyway so its the same result as if this was not added in.
|
I also had thought of using filter_var but I think it's a bit overboard for validation of value but allows for "1", "yes", "true", "on", all of the 'non-standard' enable keywords for env var values.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows for control of it's enable state.
I think this should be something included out of the box, I know its a simple change but its something that I think it's helpful as lots of things are controlled via ENV vars in the end.
I have it reading the ENV Value and checking if its string(true), if so then true otherwise false.
If no value is passed in then it defaults to true anyway so its the same result as if this was not added in.