Prepend root_path to meta path in HttpWasmAssetReader
#10527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cart
approved these changes
Nov 14, 2023
cart
pushed a commit
that referenced
this pull request
Nov 30, 2023
# Objective Fixes an issue where Bevy will look for `.meta` files in the root of the server instead of `imported_assets/Default` on the web. ## Solution `self.root_path.join` was seemingly forgotten in the `read_meta` function on `HttpWasmAssetReader`, though it was included in the `read` function. This PR simply adds the missing function call.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…0527) # Objective Fixes an issue where Bevy will look for `.meta` files in the root of the server instead of `imported_assets/Default` on the web. ## Solution `self.root_path.join` was seemingly forgotten in the `read_meta` function on `HttpWasmAssetReader`, though it was included in the `read` function. This PR simply adds the missing function call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes an issue where Bevy will look for
.metafiles in the root of the server instead ofimported_assets/Defaulton the web.Solution
self.root_path.joinwas seemingly forgotten in theread_metafunction onHttpWasmAssetReader, though it was included in thereadfunction. This PR simply adds the missing function call.