Skip to content

feat(jsruntime): closures #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Jul 20, 2024
Merged

feat(jsruntime): closures #236

merged 40 commits into from
Jul 20, 2024

Conversation

masnagam
Copy link
Member

@masnagam masnagam commented Jul 18, 2024

on my PC:

  • about 3% faster in fib8.js than before
  • about 3% slower in fib32.js than before

Closes: #195

@masnagam masnagam self-assigned this Jul 18, 2024
@masnagam
Copy link
Member Author

masnagam commented Jul 19, 2024

installing llvm failed due to llvm/llvm-project#99502

@masnagam masnagam force-pushed the feat-jsruntime-closures branch from 4d99ca8 to 41162f5 Compare July 19, 2024 10:08
Copy link

github-actions bot commented Jul 19, 2024

🐰Bencher

ReportSat, July 20, 2024 at 02:17:25 UTC
Projectbee-browser
Branch236/merge
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
htmlparser/parse/lipsum.html➖ (view plot)289,330.00
htmlparser/parse/medium-fragment.html➖ (view plot)98,588.00
htmlparser/parse/wikipedia.html➖ (view plot)5,890,500.00
jsruntime/fib/16➖ (view plot)6,165,400.00
jsruntime/fib/24➖ (view plot)7,891,400.00
jsruntime/fib/32➖ (view plot)106,540,000.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@masnagam masnagam force-pushed the feat-jsruntime-closures branch from 41162f5 to fd9a400 Compare July 19, 2024 11:52
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 85.65517% with 104 lines in your changes missing coverage. Please review.

Project coverage is 78.30%. Comparing base (e635836) to head (6e3b7ea).

Files Patch % Lines
libs/jsruntime/src/semantics/scope.rs 82.48% 30 Missing and 1 partial ⚠️
libs/jsruntime/src/bridge/mod.rs 71.27% 27 Missing ⚠️
libs/jsruntime/src/semantics/mod.rs 92.85% 23 Missing ⚠️
bins/jstb/src/main.rs 0.00% 20 Missing ⚠️
libs/jsruntime/src/function.rs 91.42% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   78.20%   78.30%   +0.10%     
==========================================
  Files          65       65              
  Lines       20244    20640     +396     
  Branches    20244    20640     +396     
==========================================
+ Hits        15831    16163     +332     
- Misses       4181     4246      +65     
+ Partials      232      231       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masnagam masnagam force-pushed the feat-jsruntime-closures branch from fd9a400 to 5a4a290 Compare July 19, 2024 23:53
@masnagam masnagam merged commit daceac5 into main Jul 20, 2024
6 checks passed
@masnagam masnagam deleted the feat-jsruntime-closures branch July 20, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jsruntime): closures
1 participant