Skip to content

Convert badge to png #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2018
Merged

Convert badge to png #34

merged 2 commits into from
Nov 22, 2018

Conversation

patricksimonian
Copy link
Contributor

About

SVG files are not fetchable in the devhub and so the badges appear as broken images.

I converted the SVG files into PNG's as a work around.
.https://taiga.pathfinder.gov.bc.ca/project/lukegonis-developergovbcca/issue/684

@jleach
Copy link
Member

jleach commented Nov 22, 2018

What makes them non-fetchable?

@patricksimonian
Copy link
Contributor Author

@jleach from what I've read so far, svg files are unable to request external resources.
comment from github markup issue 556

@kivikakk That's absolutely correct (based on my own research into this). Referencing an SVG using an <img> tag rasterizes the image and prevents it from further loading anything. It's basically inert.

Here's the most relevant literature I know about what SVG features are available when using the <img> tag: https://www.smashingmagazine.com/2014/11/styling-and-animating-svgs-with-css/#embedding-svgs

This is the key clause:

Styles and animations applied to an SVG using an external CSS resource will not be preserved once the SVG is embedded.

Basically, the SVG can't make any external references.

@patricksimonian patricksimonian merged commit acf30af into master Nov 22, 2018
@orinevares orinevares deleted the convert-badge-to-png branch March 28, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants