Skip to content

Specify repository branch for 5.x #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ivankravets
Copy link
Contributor

No description provided.

@ivankravets
Copy link
Contributor Author

Hi @bblanchon,

Thank you so much for your library and efforts! I see you removed "master" branch and we have 2 branches now. Actually, we can switch PlatformIO Registry to the latest 6.x. I saw people use your library in different places without Semantic Versioning. It means, that PlatformIO could start downloading latest 6.x which is not compatible with their projects. Am I correct?

Should we stay at 5.x branch?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8ea5fe1 on ivankravets:patch-1 into ad4b13c on bblanchon:5.x.

@bblanchon
Copy link
Owner

Hi @ivankravets,

Yes, I think it's time to switch to v6.
What do I need to do?

Regards,
Benoit

@ivankravets
Copy link
Contributor Author

Nothing! I've just switched manifest to 6.x. See https://platformio.org/lib/show/64/ArduinoJson

Thanks!

@ivankravets ivankravets closed this Mar 5, 2019
Repository owner locked and limited conversation to collaborators Apr 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants