This repository was archived by the owner on Sep 16, 2021. It is now read-only.
fix: tsetse checker must be initialized with latest program #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
force-pushed
the
tsserver-plugin
branch
from
9f7141b to
e96a62e
Compare
Since ts.Program is an immutable data structure, the tsetse checker must get hold of a new instance of the ts.Program every time `getSemanticDiagnostics` is called. There is no way to do this currently, so just create a new tsetse Checker instance every time.
kyliau
force-pushed
the
tsserver-plugin
branch
from
e96a62e to
b494092
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ts.Program is an immutable data structure, the tsetse checker
must get hold of a new instance of the ts.Program every time
getSemanticDiagnosticsis called. There is no way to do this currently,so just create a new tsetse Checker instance every time.
Attention Googlers: This repo has its Source of Truth in Piper. After sending a PR, you can follow http://g3doc/third_party/bazel_rules/rules_typescript/README.google.md#merging-changes to get your change merged.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information