2.x: Support index-import on all Xcode 16.x versions #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/update-hash-algorithm-for-xcode-16.3-rules_swift-2.x
branch
from
c5400d3 to
33b84dd
Compare
This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under.
luispadron
force-pushed
the
luis/update-hash-algorithm-for-xcode-16.3-rules_swift-2.x
branch
from
33b84dd to
49306d7
Compare
luispadron
changed the title
luispadron
requested review from
BalestraPatrick,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
keith
approved these changes
Apr 3, 2025
|
@keith im actually going to drop the apple_support update from the 2.x branch unless you think its fine to drop support for Bazel 6 like this? |
|
yea sounds fine, this branch doesn't need to support last_green |
|
you can remove that ci config for this branch instead |
luispadron
force-pushed
the
luis/update-hash-algorithm-for-xcode-16.3-rules_swift-2.x
branch
from
56a035e to
dbde6f7
Compare
luispadron
deleted the
luis/update-hash-algorithm-for-xcode-16.3-rules_swift-2.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1.
To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under.