Make scala_xxx rules declare that they provide JavaInfo #1643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Made scala_xxx rules declare they provide JavaInfo by setting the provides attribute. - This allows aspects to visit them when the aspect uses required_providers. - This matches functionality of java_xxx rules
crt-31
force-pushed
the
add_provides_javainfo
branch
from
909cd41 to
5f8d225
Compare
|
Looks like you need to run |
simuons
approved these changes
Nov 9, 2024
liucijus
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made most scala_xxxx rules declare that they provide JavaInfo (setting the "provides" attribute).
This allows these targets to be visited by aspects that use "required_providers=[JavaInfo]".
This matches behavior in java_xxx rules, and goal was to address all the equivelant scala_xxx rules.
rules updated are: scala_import, scala_library, scala_binary, scala_test, scala_junit_test, scala_proto, and scala_repl. (scala_proto_library was already correct).
Motivation
Allows scala_xxx rules to be visited by aspects that use "required_providers=[JavaInfo]"