Skip to content

Add scala_export #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

vinnybod
Copy link
Contributor

@vinnybod vinnybod commented Sep 27, 2024

This adds a scala_export macro that works the same way as java_export and kt_jvm_export.
I'd like to add the scaladoc classifier artifact generation in a follow up PR.

@vinnybod vinnybod force-pushed the upstream-scala-export branch from 835cce8 to b54782d Compare September 27, 2024 21:23
@shs96c
Copy link
Collaborator

shs96c commented Oct 22, 2024

I'm wondering whether we should push both the kotlin_export and scala_export to their respective rulesets. We're introducing a circular dependency between those rulesets and rules_jvm_external, and we'd require people who are using these targets to have those rulesets available to them anyway.

Could you please open this PR against rules_scala, and I'll do the same for the kotlin rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants