Compatibility with python 3.10 and 3.11 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one test fails due to ordereddict's new __repr__ in 3.12
A bit cleaner looking, and also supports 3.10/3.11
simplifies number of code changes
conditionally do repr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Description of changes:
Hi @nateprewitt and @jonathan343
Thanks for a great tool! This is quite useful for making requests directly to aws services.
It would be useful to me to have this library work with earlier python versions. I have played around with using the signers in 3.10 and 3.11, and it doesn't seem like there's much issue beyond what has been modified in this PR.
I have this as a draft for the following reasons:
mypyversion inpyproject.tomlat 3.12, even though it really should be compatible with all 3 versions. But, I don't believe mypy python version specifications can be an array in a pyproject. I'm not exactly sure what it's being used for right now. If it's just for thepre-commitaction, then I'm not sure my matrix of lint tests are working properly.