make the runtime client's user agent overrideable #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomagdy
reviewed
Oct 21, 2020
src/runtime.cpp
Outdated
| {} | ||
|
|
||
| runtime::runtime(std::string const& endpoint, std::string const& user_agent) | ||
| : m_user_agent_header("User-Agent: " + user_agent + ""), |
There was a problem hiding this comment.
What's the last empty string for?
There was a problem hiding this comment.
nothing, I did a bad job cleaning up from a previous revision
marcomagdy
reviewed
Oct 21, 2020
src/runtime.cpp
Outdated
Comment on lines
160
to
164
| runtime::runtime(std::string const& endpoint) : runtime(endpoint, "AWS_Lambda_Cpp/" + std::string(get_version())) | ||
| {} | ||
|
|
||
| runtime::runtime(std::string const& endpoint, std::string const& user_agent) | ||
| : m_user_agent_header("User-Agent: " + user_agent), |
There was a problem hiding this comment.
I think clang-format is complaining about this.
run clang-format, or just paste the following.
runtime::runtime(std::string const& endpoint) : runtime(endpoint, "AWS_Lambda_Cpp/" + std::string(get_version())) {}
runtime::runtime(std::string const& endpoint, std::string const& user_agent)
: m_user_agent_header("User-Agent: " + user_agent), m_endpoints{{endpoint + "/2018-06-01/runtime/init/error",
endpoint + "/2018-06-01/runtime/invocation/next",
endpoint + "/2018-06-01/runtime/invocation/"}},
m_curl_handle(curl_easy_init())
|
LGTM just fix the formatting, and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We use aws-lambda-cpp as a building block for other runtimes. This change lets us choose our own custom user agent for internal tracking.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.