Skip to content

V4: Fixed an issue where NullReferenceException was thrown while invoking AmazonCloudFormationClient.UpdateStackAsync(). #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

V4: Fixed an issue where NullReferenceException was thrown while invoking AmazonCloudFormationClient.UpdateStackAsync(). #3835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions generator/.DevConfigs/66b6150c-da38-4673-9313-83bf9e38a90e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"services": [
{
"serviceName": "CloudFormation",
"type": "patch",
"changeLogMessages": [ "Fixed an issue where NullReferenceException was thrown while invoking AmazonCloudFormationClient.UpdateStackAsync()." ]
}
]
}
19 changes: 14 additions & 5 deletions sdk/src/Services/CloudFormation/Custom/Internal/ProcessRequestHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,22 @@ protected virtual void PreInvoke(IExecutionContext executionContext)
if (updateStackRequest != null)
{
var arns = updateStackRequest.NotificationARNs;
bool arnsAutoConstructed = arns is AutoConstructedList<string>;

// if there are no NotificationARNs and the list was created by user (type is NOT AutoConstructed)
// only then pass empty param
if (arns.Count == 0 && !arnsAutoConstructed)
if (arns != null)
{
request.Parameters.Add("NotificationARNs", "");
// if there are no NotificationARNs and the list was created by user (type is NOT AutoConstructed)
// only then pass empty param
if (arns.Count == 0 && !(arns is AutoConstructedList<string>))
{
if (request.Parameters.ContainsKey("NotificationARNs"))
{
request.Parameters["NotificationARNs"] = string.Empty;
}
else
{
request.Parameters.Add("NotificationARNs", string.Empty);
}
}
}
}
}
Expand Down
80 changes: 80 additions & 0 deletions sdk/test/Services/CloudFormation/IntegrationTests/CloudFormation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,86 @@ public void TestCreateStack()
}
}

[TestMethod]
[TestCategory("CloudFormation")]
public void TestUpdateStack()
{
string stackName = "test-stack-" + DateTime.UtcNow.Ticks;
try
{
CreateStackRequest createRequest = new CreateStackRequest
{
StackName = stackName,
TemplateBody = TEMPLATE_TEXT,
Parameters = new List<Parameter>
{
new Parameter
{
ParameterKey = "TopicName",
ParameterValue = "MyTopic" + DateTime.UtcNow.Ticks
},
new Parameter
{
ParameterKey = "QueueName",
ParameterValue = "MyQueue" + DateTime.UtcNow.Ticks
}
}
};

Client.CreateStack(createRequest);
WaitTillStackNotInProcess(stackName);

UpdateStackRequest updateStackRequest = new UpdateStackRequest
{
StackName = stackName,
TemplateBody = TEMPLATE_TEXT,
Parameters = new List<Parameter>
{
new Parameter
{
ParameterKey = "TopicName",
ParameterValue = "MyTopic" + DateTime.UtcNow.Ticks
},
new Parameter
{
ParameterKey = "QueueName",
ParameterValue = "MyQueue" + DateTime.UtcNow.Ticks
}
}
};

Client.UpdateStack(updateStackRequest);
WaitTillStackNotInProcess(stackName);

updateStackRequest = new UpdateStackRequest
{
StackName = stackName,
TemplateBody = TEMPLATE_TEXT,
Parameters = new List<Parameter>
{
new Parameter
{
ParameterKey = "TopicName",
ParameterValue = "MyTopic" + DateTime.UtcNow.Ticks
},
new Parameter
{
ParameterKey = "QueueName",
ParameterValue = "MyQueue" + DateTime.UtcNow.Ticks
}
},
NotificationARNs = new List<string>()
};
Client.UpdateStack(updateStackRequest);
WaitTillStackNotInProcess(stackName);
}
finally
{
WaitTillStackNotInProcess(stackName);
Client.DeleteStack(new DeleteStackRequest() { StackName = stackName });
}
}

static void WaitTillStackNotInProcess(string stackname)
{
DescribeStacksResponse response = null;
Expand Down