Add tool for generating the DevConfig file #3811
Conversation
|
I played around with it a bit, this is neat. Thanks for making the devconfig process easier! |
| public List<Service> Services { get; } = new List<Service>(); | ||
| } | ||
|
|
||
| public class CoreChange |
There was a problem hiding this comment.
It would be useful to have backwardIncompatibilitiesToIgnore but can be in a future version.
| writer.WriteStartObject("core"); | ||
|
|
||
| writer.WriteBoolean("updateMinimum", config.Core.UpdateServiceMinimum); | ||
| writer.WriteString("type", config.Core.Type); |
There was a problem hiding this comment.
Should validate Type being either minor or patch in the future. Any other value isn't technically supported right now for basic DevConfigs.
|
|
||
| void GeneratorChange() | ||
| { | ||
| AnsiConsole.Markup("Generator changes are saved as [green]Core changes[/] with update service minimum set to [green]true[/].\n"); |
There was a problem hiding this comment.
A generator change doesn't always means a core update is needed. Usually it requires a change to a specific service unless it impacts many of them.
| var service = devConfig.Services.FirstOrDefault(x => x.Name == serviceName); | ||
| if (service == null) | ||
| { | ||
| service = new Service { Name = serviceName }; |
There was a problem hiding this comment.
When would this case be valid? It seems like it would either be a mistake name entered that has no match or trying to specify a new service which would have a folder name. Looks like this could lead to invalid devconfigs.
Description
I got tired of manually creating DevConfig files or explaining to contributors how to create a DevConfig file so I thought I add a console tool build tools for helping generating the DevConfig file would be helpful. At least it would give a head start on the file and users could later further modify the generated file.