Skip to content

Fix bootstrap script #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Fix bootstrap script #938

merged 1 commit into from
May 16, 2025

Conversation

GarrettBeatty
Copy link
Contributor

@GarrettBeatty GarrettBeatty commented May 15, 2025

Issue #, if available:
Fix handling case where branch already exists. Ran it manually and it successfully made #937 (review)

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@GarrettBeatty GarrettBeatty added the Release Not Needed Add this label if a PR does not need to be released. label May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.54%. Comparing base (40f7920) to head (3282fd5).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #938      +/-   ##
==========================================
- Coverage   63.55%   63.54%   -0.02%     
==========================================
  Files         284      284              
  Lines       11040    11040              
  Branches     1537     1537              
==========================================
- Hits         7017     7015       -2     
  Misses       3470     3470              
- Partials      553      555       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -104,4 +114,4 @@ jobs:
--title "Update CDK Bootstrap Template to Version ${{ steps.check_version.outputs.new_version }}" \
--base dev \
--head update-cdk-bootstrap-template \
--delete-branch
--fill
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will auto generate pr description via the commit id

@GarrettBeatty GarrettBeatty merged commit e0dadbb into dev May 16, 2025
9 of 12 checks passed
@GarrettBeatty GarrettBeatty deleted the gcbeatty/bootstrapupdates branch May 16, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Not Needed Add this label if a PR does not need to be released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants