Skip to content

CFN Package: MD5 Files In Zip For Proper Dedupe #4526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

wmonk
Copy link

@wmonk wmonk commented Sep 25, 2019

Issue #, if available: #3131

Description of changes: When creating the zip file to be uploaded to s3 as part of aws cloudformation package it now:

  1. stores the file names
  2. sorts them
  3. loops over all files and adds the file name and content to an md5
  4. creates a hex digest
  5. uploads the zip to s3 with the hex digest as the name

This means next time aws cloudformation package is run, it won't duplicate, and in turn the changeset will be empty - effectively a noop. This is more useful when your package code is more discrete, so your lambda functions can be deployed independently of each other if no code has changed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Hyardaowyn
Copy link

@wmonk I see that the tests for python 2.x are failing, are you still planning on looking at them?

@wmonk
Copy link
Author

wmonk commented Aug 19, 2020

@Hyardaowyn no I'm not planning on working on this anymore.

@wmonk wmonk closed this Aug 19, 2020
@KapitalEarth
Copy link

KapitalEarth commented Aug 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants