fix(api): cognito user pool intercept with accessToken #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royjit
approved these changes
Aug 10, 2020
| func testGetAPIFailedWithNotAuthenticated() { | ||
| AuthHelper.signOut() | ||
| func testGetAPIFailedWithSignedOutError() { | ||
| signOut() |
There was a problem hiding this comment.
User is already signout at this stage, do we need to call it again?
There was a problem hiding this comment.
ah no need to call it again, i had this when i was debugging the tests, in a normal test run, this is covered already in the tearDown. removing this line
lawmicha
commented
Aug 10, 2020
...ntegrationTests/REST/RESTWithUserPoolIntegrationTests/RESTWithUserPoolIntegrationTests.swift
Outdated
Show resolved
Hide resolved
…ESTWithUserPoolIntegrationTests/RESTWithUserPoolIntegrationTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#618
Description of changes:
This updates the Cognito User Pool interceptor to use the accessToken. Android and JS is using accessToken, while iOS was using idToken before. According to the AWS docs, both can be passed to the service.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.