fix: Plugins that are not configured correctly will be error at initial step #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
approved these changes
Jul 15, 2020
| try plugin.configure(using: nil) | ||
| XCTFail("Analytics configuration should not succeed") | ||
| } catch { | ||
| guard let apiError = error as? PluginError, |
There was a problem hiding this comment.
I assume we're not really throwing an API error here, it's just a misnamed variable?
| try plugin.configure(using: nil) | ||
| XCTFail("Auth configuration should not succeed") | ||
| } catch { | ||
| guard let apiError = error as? PluginError, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #480
Description of changes:
This change allows to call configure method of each plugin with a nil value. ie even if the corresponding configuration is not present in the configuration file, plugin's configure will be called.
Issue we are solving:
Suppose that I added two plugins to my project
AWSAPIPluginandAWSDataStorePlugin, but forgot to add any configuration for API in myamplifyconfiguration.json. Since there is no configuration the current logic does not invoke theconfigure(:)function ofAWSAPIPlugin. So we end up using a not-configured plugin and end up in unintended error or crash like this - #480Thought process behind this change:
All category in Amplify conforms to the protocol - CategoryConfigurable, which could infer that the plugins added to every category is configurable. Since each added plugin is configurable it should be given a chance to configure even if the corresponding configuration is missing. This will give the plugin a chance to decide whether it can work in a non-configuration based situation or throw an error.
Other changes in this PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.