delete redundant txn cookies impl, tests and some linting changes #2077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
==========================================
+ Coverage 82.05% 82.25% +0.19%
==========================================
Files 21 21
Lines 1967 1989 +22
Branches 343 348 +5
==========================================
+ Hits 1614 1636 +22
Misses 347 347
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
Comment on lines
+121
to
+146
| vi.spyOn(oauth, "validateAuthResponse").mockReturnValue( | ||
| new URLSearchParams("code=auth_code") | ||
| ); | ||
| vi.spyOn(oauth, "authorizationCodeGrantRequest").mockResolvedValue( | ||
| new Response() | ||
| ); | ||
| vi.spyOn(oauth, "processAuthorizationCodeResponse").mockResolvedValue({ | ||
| token_type: "Bearer", | ||
| access_token: "access_token_123", | ||
| id_token: "id_token_456", | ||
| refresh_token: "refresh_token_789", | ||
| expires_in: 3600, | ||
| scope: "openid profile email" | ||
| } as oauth.TokenEndpointResponse); | ||
|
|
||
| const clientId = baseOptions.clientId ?? "test-client-id"; | ||
| vi.spyOn(oauth, "getValidatedIdTokenClaims").mockReturnValue({ | ||
| sub: "user123", | ||
| sid: "sid123", | ||
| nonce: "test-nonce", | ||
| aud: clientId, | ||
| iss: `https://${baseOptions.domain}/`, | ||
| iat: Math.floor(Date.now() / 1000) - 60, | ||
| exp: Math.floor(Date.now() / 1000) + 3600 | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Why do we need all that mocking?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1917
Overview
The original logout handler (
handleLogout) only deleted the session cookie, leaving transaction cookies behind.This caused potential accumulation of transaction state cookies (
__txn_{state}) for users, particularly those who were unauthenticated or experienced interrupted login flows.Changes
AuthClient.handleLogoutto actively clear all transaction cookies (matching the transaction store's cookie prefix)getCookiePrefixtoTransactionStoreredundant-txn-cookie-deletion.test.tsto test this specific flow.Tests
PASSING
Usage
No change in contract