Fix problem with class shadowing on 2.13.2+ #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes as well: * Update Scala to 2.13.1 * Update kind-projector to 0.11.0
augustjune
approved these changes
Mar 21, 2020
|
That's an excellent PR, @ybasket! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Scala 2.13.2, it is no longer allowed to define an inner class with the same name as an inner class in the super class of the outer: scala/bug#8353
As context-applied generates such class names when you extend a class which has a context bound with the same name, it generates a warning, for example in profunktor/redis4cats#244. This PR fixes that by appending the outer class' name to make it unique.
Includes as well:
To reproduce the problem itself, do the following:
"org.typelevel" % "kind-projector_2.13.1" % "0.11.0"set ThisBuild/resolvers += "scala-integration" at "https://scala-ci.typesafe.com/artifactory/scala-integration/"++2.13.2-bin-53ba87a!compile- fails on the new test inshadowed.scala