Skip to content

Stream::any implementation #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2019
Merged

Stream::any implementation #135

merged 3 commits into from
Sep 1, 2019

Conversation

shekohex
Copy link
Contributor

  • Adds stream::any implementation.
  • update method docs
  • an example for stream all method.
  • tests

this PR is just copy/pasted from #132 with just small changes in the logic.
is there a way that we can reuse the same code here?
I think it's fine.

shekohex
shekohex commented Aug 31, 2019
View reviewed changes
@shekohex
Copy link
Contributor Author

@jamesmunns could you please review this quickly and merge it so I can work on other methods?

yoshuawuyts
yoshuawuyts requested changes Aug 31, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor API nit. Because this returns a future, not a stream there is no counterpart in stdlib and we should probably keep it hidden so once async traits work we can swap it over without breaking the API.

laizy
laizy reviewed Sep 1, 2019
View reviewed changes
@shekohex
Copy link
Contributor Author

shekohex commented Sep 1, 2019

Hi @yoshuawuyts could you please review the new changes?

yoshuawuyts
yoshuawuyts approved these changes Sep 1, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yoshuawuyts yoshuawuyts merged commit bff10fe into async-rs:master Sep 1, 2019
@shekohex shekohex deleted the stream-any-method branch September 1, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laizy laizy laizy left review comments

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekohex @yoshuawuyts @laizy