Escape Pattern before being passed to glob #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Thank you! Do you mind commenting here (to send me a notification) when this is released to crates.io? |
|
It is already released. v0.17.0 |
|
Thank you!!
…On Wed, May 29, 2024, 7:49 AM aston ***@***.***> wrote:
It is already released. v0.17.0
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYKZ3LQI5MFYYEZHEYAXTZEW6EXAVCNFSM6AAAAABIIGLAQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXGIYTSOBYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
JAVA_HOMEcontains a character that can be interpreted as a glob, this causes this crate to fail to find the JVM. This usesPattern::escapeprior to calling glob & adds a test.In the second commit, I took the liberty of running
cargo fmt.