This repository was archived by the owner on Dec 29, 2021. It is now read-only.
Option to ignore output #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. This is not a breaking change, is it? Can you maybe also bump the version number? I'll publish it right after merging. |
|
It isn't a breaking change, I only added new functions and the macro still matches what it did before in the same way. |
|
@homu r+ |
|
📌 Commit 4fb51df has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jul 10, 2016
Option to ignore output Fixes #6. I was thinking about whether to implement it as interpreting an empty string as matching any output, but I can see how many situations might call for explicitly expecting a command not to output (such as when testing a quiet mode). Is this alright? Also, I think fuzzy matching should be a new issue. It would be a much different of an implementation than #6.
|
0.2.2 is on crates.io: https://crates.io/crates/assert_cli |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6. I was thinking about whether to implement it as interpreting an empty string as matching any output, but I can see how many situations might call for explicitly expecting a command not to output (such as when testing a quiet mode). Is this alright?
Also, I think fuzzy matching should be a new issue. It would be a much different of an implementation than #6.