PathString implicit string converters are asymmetric

[jkotalik]

In PathString.cs

public static implicit operator PathString(string s)
        {
            return new PathString(s);
        }

Will create the unescaped new PathString while

        public static implicit operator string(PathString path)
        {
            return path.ToString();
        }

Will create the escaped ToString.

[davidfowl]

That's not great...

[khellang]

I thought that was the whole point of PathString? Make it easier to do "the right thing" by expecting unescaped and outputting an escaped string. This prevents someone accidentally ToString'ing a path in its unescaped form.

[Tratcher]

@khellang We didn't specify which was wrong, just that it's asymmetric. If anything I think it's the string -> PathString converter that's wrong, it should use FromUriComponent to maintain symmetry. Unfortunately that's not how we normally to use it either.

[muratg]

This would be a breaking change. We'll reconsider in 2.0

[Tratcher]

@muratg we should re-triage this if we're ever going to fix it.

[HaoK]

12f89f6