feat: add examples of Rust and TypeScript #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
approved these changes
Mar 18, 2025
Rust depends on having one that works. We can find a more surgical way to prevent protoc cc_binary from getting built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike Go and Python, these examples include gRPC clients and servers. You can test this by starting the server in any language, then run clients in all the languages.
The way I've been asserting that
protocisn't built from source is by registering a fake C++ toolchain which always runs/bin/falseas the compiler. But Rust expects to be able to piggy-back on the cc toolchain so that doesn't work anymore. We need a more surgical way to make CI red if we start compilingprotoc.Fixes #34