Skip to content

Bugfix Windows missing cursor on editor #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

murilopolese
Copy link
Contributor

Problem

#141

How to reproduce

This bug on the cursor happens every time a "confirmation" dialog is triggered. You can trigger it by:

  • Removing a file
  • Trying to close the window with unsaved changes and clicking "cancel"
  • Performing overwriting operations

Solution

Switch from frontend confirm to use Electron's dialog.showMessageBoxSync.
https://www.electronjs.org/docs/latest/api/dialog#dialogshowmessageboxsyncwndow-options

@murilopolese murilopolese requested a review from ubidefeo December 2, 2024 09:42
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been successfully tested on Windows and resolves the issue

@murilopolese murilopolese merged commit 345a7b3 into development Dec 3, 2024
1 check passed
@ubidefeo ubidefeo deleted the bugfix/windows-focus branch December 5, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants