Prompting to save before quit also for new files #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When the editor opens it creates an "empty" file and show that to the user at start.
When closing the editor, it will check for unsaved changes on the opened tabs and prompt the user if they are really sure they want to quit.
Problem
The new file that appears at the start of the editor is not part of the "check for unsaved changes" because that file has never been saved. Apparently this is due people thinking they had saved their code using "cmd+s" or "ctrl+s".
Solution
When quitting the app, include the "new files" on the check for unsaved changes.