Skip to content

Show filename transfer #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2024
Merged

Show filename transfer #120

merged 3 commits into from
Nov 11, 2024

Conversation

murilopolese
Copy link
Contributor

Show name of the file being transferred.

@murilopolese murilopolese requested a review from ubidefeo April 25, 2024 09:46
ubidefeo
ubidefeo reviewed Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still only see "Transferring file" and the percentage on the next line.
no file name

ubidefeo
ubidefeo approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing file names for folder uploads will come later, single file(s) uploads will show the file name

@murilopolese
Copy link
Contributor Author

I will have a look on how to show the name of the files that are being uploaded inside the folders, shouldn't be hard.

Base automatically changed from development to main April 29, 2024 06:54
@murilopolese murilopolese changed the base branch from main to development November 7, 2024 11:22
@murilopolese
Copy link
Contributor Author

Included the file names with relative path to the folder upload:

Screenshot from 2024-11-07 08-50-11

@murilopolese murilopolese requested a review from ubidefeo November 7, 2024 12:35
ubidefeo
ubidefeo approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transferred a folder with 3 levels of subfolders down.
worked as expected

@murilopolese murilopolese merged commit 4e139e6 into development Nov 11, 2024
1 check passed
@murilopolese murilopolese deleted the feature/show-filename-transfer branch November 11, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murilopolese @ubidefeo