Skip to content

[dev]: Clean up daemon address parsing tests #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
kittaakos opened this issue Oct 24, 2022 · 0 comments
Open
3 tasks done

[dev]: Clean up daemon address parsing tests #1576

kittaakos opened this issue Oct 24, 2022 · 0 comments
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Comments

@kittaakos
Copy link
Contributor

Describe the request

This is a follow-up of #1570.

Extracted from here:

There are multiple remarks:

  • initially, the CLI did not print out the daemon port, so it had to work with both json and text. That's why we had tests.
  • currently, it does not matter whether text or json is given after the --log-format because the address format is dictated by the daemon --format jsonmini|text|json flags.

Describe the current behavior

We should have tests that independently from the --config-format (json or text), can parse the daemon address (hostname and port).

Arduino IDE version

32d904c

Operating system

macOS

Operating system version

12.5.1

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Oct 24, 2022
@kittaakos kittaakos self-assigned this Oct 24, 2022
@per1234 per1234 added topic: infrastructure Related to project infrastructure and removed topic: code Related to content of the project itself labels Oct 27, 2022
@kittaakos kittaakos removed their assignment Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

2 participants