Skip to content

Library with invalid depends field causes silent failures #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
per1234 opened this issue Dec 30, 2019 · 0 comments · Fixed by #544
Closed

Library with invalid depends field causes silent failures #534

per1234 opened this issue Dec 30, 2019 · 0 comments · Fixed by #544
Assignees
@cmaglie
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: package-management Related to the packaging and managing of the platform/libraries type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Dec 30, 2019

Bug Report

The MD_Parola library version 3.2.0 has a depends field in library.properties that contains a misspelled library name (https://github.com/MajicDesigns/MD_Parola/blob/v3.2.0/library.properties#L11). This causes arduino-cli lib deps and arduino-cli lib install to fail silently.

Current behavior

arduino-cli lib deps [email protected]

No dependencies are listed (normally MD_Parola would be listed even if there were no other dependencies defined).

arduino-cli lib install [email protected]

The library is not installed and no error message is displayed.

Expected behavior

Ignore invalid dependency names. Perhaps provide a warning message, but continue executing the command anyway.

Environment

  • CLI version (output of arduino-cli version): 0.7.0-rc1 Commit: 49897ef
  • OS and platform: Windows 10 64 bit, Ubuntu 19.04

Additional context

The Arduino IDE also displays undesirable behavior when installing [email protected]. I did not submit a separate report for that because I thought it might be resolved by fixing the issue in arduino-cli.
@cmaglie cmaglie self-assigned this Jan 7, 2020
cmaglie added a commit to cmaglie/arduino-cli that referenced this issue Jan 7, 2020
@cmaglie
Libraries dependencies: output error if no valid solution found
ca8c522 
Fix arduino#534
@cmaglie cmaglie mentioned this issue Jan 7, 2020
Closed
cmaglie added a commit to cmaglie/arduino-cli that referenced this issue Jan 7, 2020
@cmaglie
Libraries dependencies: output error if no valid solution found
8edbbe9 
Fix arduino#534
@cmaglie cmaglie mentioned this issue Jan 7, 2020
Merged
cmaglie added a commit that referenced this issue Jan 30, 2020
@cmaglie
Libraries dependencies: output error if no valid solution found (#544)
afdf259 
Fix #534
@per1234 per1234 mentioned this issue Jul 14, 2021
Merged
@per1234 per1234 added conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: package-management Related to the packaging and managing of the platform/libraries labels May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmaglie cmaglie

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: package-management Related to the packaging and managing of the platform/libraries type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
2 participants
@cmaglie @per1234