Overload beginTransmission and requestFrom to support using an external buffer #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
lupalby
suggested changes
Dec 22, 2017
| } | ||
| else | ||
| { | ||
| if ( externalTxBufferLength == externalTxBufferQuantity ) |
| } | ||
|
|
||
| void TwoWire::beginTransmission(uint8_t address) { | ||
| void TwoWire::beginTransmission(uint8_t address, uint8_t buffer[], size_t length, size_t quantity) { |
There was a problem hiding this comment.
I think the name of the arguments in beginTransmission is confusing. How about bufferLength and usedBytes?
|
Some time ago we all discussed an "addMemory" API to be added to HardwareSerial, Wire, and other libs. I believe @facchinm made an initial implementation, but it never left a branch on his fork, maybe due to lack of agreement over the API details? Is that idea gone now? Is passing pointers really going to become the Arduino API? |
boseji
pushed a commit
to go-ut/combined-ArduinoCore-samd
that referenced
this pull request
May 12, 2021
Fix [-Wrestrict] bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #269, with updated API's based on the discussion with @lupalby.
Wire. requestFrom(...)andWire.beginTransmission(...)are overloaded to support external buffers.The external buffer for TX can optionally be partially or fully pre-populated with data. The existing
StreamandPrintAPI's can continue to be used to populate the external buffer.