Allow General Calls on I2C bus (aka broadcast) #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agdl
changed the title
sandeepmistry
approved these changes
Dec 11, 2017
facchinm
reviewed
Dec 12, 2017
cores/arduino/SERCOM.cpp
Outdated
| @@ -400,17 +400,20 @@ void SERCOM::disableWIRE() | |||
| } | |||
| } | |||
|
|
|||
| void SERCOM::initSlaveWIRE( uint8_t ucAddress ) | |||
| void SERCOM::initSlaveWIRE( uint8_t ucAddress, bool broadcast ) | |||
There was a problem hiding this comment.
Should we call the parameter listen_on_broadcast or something similar? @sandeepmistry
There was a problem hiding this comment.
Maybe enableGeneralCall?
lupalby
approved these changes
Dec 14, 2017
sandeepmistry
approved these changes
Dec 15, 2017
|
@lupalby I think you will like this too ;) https://github.com/agdl/WireUpdate |
|
@agdl That's a cool feature! I will look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to call a Wire.begin(address, true) to enable general call (broadcast messages on address 0x00) feature on SAMD21 based devices. All the legacy calls to Wire.begin(address) are ok since the extra parameter is false by default