Skip to content

image_location config items. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

image_location config items. #3

merged 1 commit into from
Oct 18, 2024

Conversation

luodeb
Copy link
Contributor

@luodeb luodeb commented Oct 15, 2024

No description provided.

@luodeb luodeb requested a review from hky1999 October 15, 2024 05:18
Copy link
Contributor

@hky1999 hky1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to ci

@luodeb
Copy link
Contributor Author

luodeb commented Oct 15, 2024

what happened to ci

Rust nightly fails to build it,
rust-lang/rust#131602

Fix it by modifying the asm! to core::arch::naked_asm!.

@luodeb luodeb requested a review from hky1999 October 15, 2024 09:09
@hky1999
Copy link
Contributor

hky1999 commented Oct 17, 2024

what happened to ci

Rust nightly fails to build it, rust-lang/rust#131602

Fix it by modifying the asm! to core::arch::naked_asm!.

rebase to the newest main branch please, which fixed this ci problem.

this naked_asm problem has been found in ArceOS before, we just ignore it through fixed-version of rust toolchain.

you can refer to ddb72aa for details

@luodeb luodeb merged commit afd38d7 into master Oct 18, 2024
18 checks passed
@luodeb luodeb deleted the hardware branch October 18, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants