-
Notifications
You must be signed in to change notification settings - Fork 78
feature: host fallback support #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(switched to protected syntax)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start. I left some comments, some of which may not need to be addressed immediately if you are looking to do incremental changes.
Also, I'm not sure how much of this overlaps with active failover in ArangoDB (which python-arango does not have support for yet). I started a thread on it in the past but never got a chance to work on it. Hopefully that helps you in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Thanks for your contribution!
Closes #179
A (working) first-draft implementation for host fallback support.
Requires feedback
What's new:
BaseConnection.process_request()
host_index
is still being chosen using the resolver'sget_host_index
method.HostResolver.max_tries : int
HostResolver.host_count : int
RandomHostResolver.get_host_index()