improve performance of get_many
#177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by making it use a different server REST API. It now uses the low-level document API instead of the `/_api/simple/lookup-by-keys` API. The former can be used as a drop-in replacement for the latter.
joerg84
approved these changes
Oct 13, 2021
|
Looks like some dependencies around mypy is broken. Merging for now and the mypy issue can be addressed separately. |
|
@joowani : as far as I can see some of the above tests failed for reasons unrelated to this PR. Is there anything I can do to make these tests pass? Thanks! [edited] Ah, it seems we posted in this ticket at about the very same time. Will wait for the next build result then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by making it use a different server REST API. It now uses the low-level
document API instead of the
/_api/simple/lookup-by-keysAPI. Theformer can be used as a drop-in replacement for the latter.