Skip to content

Make import.sh more robust supporting more environments #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kjpopov
Copy link

@kjpopov kjpopov commented Jul 24, 2019

With this change proposal I am making import.sh more flexible to support more environments and arangosh parameters to be configurable not hardcoded to -s.

Running the current master version results to an error message probably because of an obsoleted option -s

$ arangosh -s
Error while processing command-line options for arangosh:
  unknown option '--s'

This proposed solution is tested and works well for me with arangodb v3.4.7 osx Mojave 10.14.5
and arangodb installed via brew install arangodb

@OmarAyo
Copy link

OmarAyo commented Sep 24, 2019

Hi @kjpopov

Many thanks for contributing. We are obliged by law to have a signed scanned copy of a Contributor License Agreement (CLA) to be able to accept pull requests to the official ArangoDB repository

We use an Apache 2 CLA for ArangoDB and its companion projects, which can be found here: https://www.arangodb.com/documents/cla.pdf
Just fill in the form, sign and send a scanned copy over to [email protected]

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants