Skip to content

orphaned ExecutorService blocks normal application termination #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwe17 opened this issue Oct 13, 2017 · 4 comments
Closed

orphaned ExecutorService blocks normal application termination #156

rwe17 opened this issue Oct 13, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@rwe17
Copy link

rwe17 commented Oct 13, 2017

I'm using the lastest version 4.1.4 of this driver project.
In our program, the ArangoDB is configured to use VelocyStream and a custom VPackModule, which i've configured using the ArangoDB.Builder.

The issue is, that after writing and reading Data to and from the database one active ExecutorService still remains in the JVM and prohibits the whole application for a clean termination, althought i've called ArangoDB.shutdown() at the end.

I've seen, that in the class Collection (line 136) an ExecutorService is created twice. One for operations like listing all graph names and the second when documents should be read from the database. The first ExecutorService is correctly shutdown due to the call ArangoDB.shutdown(), but the the second ExecutorService remains and causes that our program, or server will never end.

Please can you fix this in a new version or can describe a solution for this issue. Otherwise i have to switch back to an older 3.x version without supporting the Velocy conversion.

@mvollmary
Copy link

@rwe17 Thanks for reporting. I will take a look at it this week.

@mvollmary mvollmary self-assigned this Oct 16, 2017
@mvollmary
Copy link

The latest version is 4.2.4. Does the problem still occur with it?

@mvollmary mvollmary added the bug label Oct 16, 2017
@mvollmary mvollmary added this to the 4.2.5 milestone Oct 16, 2017
@rwe17
Copy link
Author

rwe17 commented Oct 16, 2017

The version with the issue was 4.2.4.
I few minutes ago, i've build the driver with your commit and tested it in our application. Your bugfix has solved my issue. Thank you very much for your quick response.

@mvollmary
Copy link

Ok great. I release version 4.2.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants